[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1731: [IOTDB-870] tags and attributes output

[GitBox <gi...@apache.org>]

qiaojialin commented on a change in pull request #1731:
URL: https://github.com/apache/incubator-iotdb/pull/1731#discussion_r488594464



##########
File path: server/src/main/java/org/apache/iotdb/db/query/dataset/ShowTimeSeriesResult.java
##########
@@ -35,17 +35,19 @@
   private String dataType;
   private String encoding;
   private String compressor;
-  private Map<String, String> tagAndAttribute;
+  private Map<String, String> tag;
+  private Map<String, String> attribute;

Review comment:
       tags and attributes are better

##########
File path: server/src/main/java/org/apache/iotdb/db/conf/IoTDBConstant.java
##########
@@ -70,6 +70,8 @@ private IoTDBConstant() {
   public static final String COLUMN_DEVICES = "devices";
   public static final String COLUMN_COLUMN = "column";
   public static final String COLUMN_COUNT = "count";
+  public static final String COLUMN_TAG = "tag";
+  public static final String COLUMN_ATTRIBUTE = "attribute";

Review comment:
       tags and attributes?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org