You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Kirby Zhou <ki...@gmail.com> on 2022/04/08 09:51:55 UTC

Review Request 73938: RANGER-3696 add log4j2 binding to elasticsearch plugin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73938/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-3696
    https://issues.apache.org/jira/browse/RANGER-3696


Repository: ranger


Description
-------

elasticsearch plugin use slf4j, but elasticsearch takes log4j2.
And there os no log4j and slf4j adapter existing.

So need to add slf4j-api and its log4j2 binding to dist package


Diffs
-----

  distro/src/main/assembly/plugin-elasticsearch.xml 0b8aaee27 
  pom.xml 5afaa39ff 
  ranger-elasticsearch-plugin-shim/pom.xml 5a02be9b5 
  ranger-plugin-classloader/pom.xml bcc02812a 


Diff: https://reviews.apache.org/r/73938/diff/1/


Testing
-------

Need somebody to verify, I can just do very simple test.


Thanks,

Kirby Zhou

Re: Review Request 73938: RANGER-3696 add log4j2 binding to elasticsearch plugin

Posted by Kirby Zhou <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73938/
-----------------------------------------------------------

(Updated ε…­ζœˆ 27, 2022, 12:22 p.m.)


Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mateen Mansoori, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy.


Changes
-------

rebase to HEAD, fix compile problem on Apple/M1


Bugs: RANGER-3696
    https://issues.apache.org/jira/browse/RANGER-3696


Repository: ranger


Description
-------

elasticsearch plugin use slf4j, but elasticsearch takes log4j2.
And there is no log4j and slf4j adapter existing.

So need to add slf4j-api and its log4j2 binding to dist package


Diffs (updated)
-----

  distro/src/main/assembly/plugin-elasticsearch.xml 0b8aaee27b8330cf1b61a03021318ef4e26891ee 
  pom.xml 4f44ef8838cb9d076970dbc71d46e70059726b1f 
  ranger-elasticsearch-plugin-shim/pom.xml 5a02be9b5d71c887985a216e31e30494287b7f84 
  ranger-plugin-classloader/pom.xml bcc02812adbb765f9f2c3c62cd0bc35084e041fb 
  security-admin/pom.xml 33ffc95e2aeebdcdb51c0dc09e1a3cb63be9074c 


Diff: https://reviews.apache.org/r/73938/diff/4/

Changes: https://reviews.apache.org/r/73938/diff/3-4/


Testing
-------

Need somebody to verify, I can just do very simple test.


Thanks,

Kirby Zhou

Re: Review Request 73938: RANGER-3696 add log4j2 binding to elasticsearch plugin

Posted by bhavik patel <bh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73938/#review224534
-----------------------------------------------------------



Please rebase the patch.

- bhavik patel


On May 10, 2022, 2:23 a.m., Kirby Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73938/
> -----------------------------------------------------------
> 
> (Updated May 10, 2022, 2:23 a.m.)
> 
> 
> Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mateen Mansoori, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3696
>     https://issues.apache.org/jira/browse/RANGER-3696
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> elasticsearch plugin use slf4j, but elasticsearch takes log4j2.
> And there is no log4j and slf4j adapter existing.
> 
> So need to add slf4j-api and its log4j2 binding to dist package
> 
> 
> Diffs
> -----
> 
>   distro/src/main/assembly/plugin-elasticsearch.xml 0b8aaee27b8330cf1b61a03021318ef4e26891ee 
>   pom.xml 7eac176c79799983101e3c2676568fc11e1d0799 
>   ranger-elasticsearch-plugin-shim/pom.xml 5a02be9b5d71c887985a216e31e30494287b7f84 
>   ranger-plugin-classloader/pom.xml bcc02812adbb765f9f2c3c62cd0bc35084e041fb 
> 
> 
> Diff: https://reviews.apache.org/r/73938/diff/3/
> 
> 
> Testing
> -------
> 
> Need somebody to verify, I can just do very simple test.
> 
> 
> Thanks,
> 
> Kirby Zhou
> 
>

Re: Review Request 73938: RANGER-3696 add log4j2 binding to elasticsearch plugin

Posted by Kirby Zhou <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73938/
-----------------------------------------------------------

(Updated δΊ”ζœˆ 10, 2022, 2:23 a.m.)


Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mateen Mansoori, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy.


Bugs: RANGER-3696
    https://issues.apache.org/jira/browse/RANGER-3696


Repository: ranger


Description
-------

elasticsearch plugin use slf4j, but elasticsearch takes log4j2.
And there os no log4j and slf4j adapter existing.

So need to add slf4j-api and its log4j2 binding to dist package


Diffs (updated)
-----

  distro/src/main/assembly/plugin-elasticsearch.xml 0b8aaee27b8330cf1b61a03021318ef4e26891ee 
  pom.xml 7eac176c79799983101e3c2676568fc11e1d0799 
  ranger-elasticsearch-plugin-shim/pom.xml 5a02be9b5d71c887985a216e31e30494287b7f84 
  ranger-plugin-classloader/pom.xml bcc02812adbb765f9f2c3c62cd0bc35084e041fb 


Diff: https://reviews.apache.org/r/73938/diff/3/

Changes: https://reviews.apache.org/r/73938/diff/2-3/


Testing
-------

Need somebody to verify, I can just do very simple test.


Thanks,

Kirby Zhou