You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/29 03:21:24 UTC
[GitHub] [skywalking-cli] kezhenxu94 opened a new pull request #39: Add
command `trace`
kezhenxu94 opened a new pull request #39: Add command `trace`
URL: https://github.com/apache/skywalking-cli/pull/39
### Motivation
Add command `trace` to query trace by trace ID and visualize the traces
### Modification
- Add command `trace` to query and visualize traces.
- Move `main.go` to `cmd`, as per the recommendation of GO CLI package structure.
- Move GraphQL query to individual `*.graphql` file, for more friendly development, with IDE plugin.
### Result
- Traces can be queried and visualized by `swctl trace <trace id>`
- GraphQL queries can be debugged in IDE, with some plugins
- Closes https://github.com/apache/skywalking/issues/3900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] wu-sheng merged pull request #39: Add command
`trace`
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #39: Add command `trace`
URL: https://github.com/apache/skywalking-cli/pull/39
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] wu-sheng commented on issue #39: Add command
`trace`
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #39: Add command `trace`
URL: https://github.com/apache/skywalking-cli/pull/39#issuecomment-605605885
Cool, do you create an interactive tree? Could you post a youtube or jpg including the interaction, this is a good twitter and documentation material.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] codecov-io edited a comment on issue #39: Add
command `trace`
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #39: Add command `trace`
URL: https://github.com/apache/skywalking-cli/pull/39#issuecomment-605553208
# [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/39?src=pr&el=h1) Report
> Merging [#39](https://codecov.io/gh/apache/skywalking-cli/pull/39?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/cae9a72c017d6b72ff97803ed69b7c17adca7767&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking-cli/pull/39?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #39 +/- ##
=======================================
Coverage 57.14% 57.14%
=======================================
Files 7 7
Lines 112 112
=======================================
Hits 64 64
Misses 40 40
Partials 8 8
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/39?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/39?src=pr&el=footer). Last update [cae9a72...97130c9](https://codecov.io/gh/apache/skywalking-cli/pull/39?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] kezhenxu94 commented on a change in pull request
#39: Add command `trace`
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #39: Add command `trace`
URL: https://github.com/apache/skywalking-cli/pull/39#discussion_r399740755
##########
File path: .graphqlconfig
##########
@@ -0,0 +1,11 @@
+{
+ "name": "SkyWalking GraphQL Schema",
+ "extensions": {
+ "endpoints": {
+ "SkyWalking GraphQL Endpoint": {
+ "url": "http://122.112.182.72:8080/graphql",
Review comment:
Anyway, fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] kezhenxu94 commented on a change in pull request
#39: Add command `trace`
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #39: Add command `trace`
URL: https://github.com/apache/skywalking-cli/pull/39#discussion_r399740321
##########
File path: .graphqlconfig
##########
@@ -0,0 +1,11 @@
+{
+ "name": "SkyWalking GraphQL Schema",
+ "extensions": {
+ "endpoints": {
+ "SkyWalking GraphQL Endpoint": {
+ "url": "http://122.112.182.72:8080/graphql",
Review comment:
Anyone who visits the main repo can get access to this address
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] codecov-io commented on issue #39: Add command
`trace`
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #39: Add command `trace`
URL: https://github.com/apache/skywalking-cli/pull/39#issuecomment-605553208
# [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/39?src=pr&el=h1) Report
> Merging [#39](https://codecov.io/gh/apache/skywalking-cli/pull/39?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/cae9a72c017d6b72ff97803ed69b7c17adca7767&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking-cli/pull/39?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #39 +/- ##
=======================================
Coverage 57.14% 57.14%
=======================================
Files 7 7
Lines 112 112
=======================================
Hits 64 64
Misses 40 40
Partials 8 8
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/39?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/39?src=pr&el=footer). Last update [cae9a72...4f19078](https://codecov.io/gh/apache/skywalking-cli/pull/39?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] wu-sheng commented on a change in pull request
#39: Add command `trace`
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #39: Add command `trace`
URL: https://github.com/apache/skywalking-cli/pull/39#discussion_r399739720
##########
File path: .graphqlconfig
##########
@@ -0,0 +1,11 @@
+{
+ "name": "SkyWalking GraphQL Schema",
+ "extensions": {
+ "endpoints": {
+ "SkyWalking GraphQL Endpoint": {
+ "url": "http://122.112.182.72:8080/graphql",
Review comment:
I think this is an IP leak.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] kezhenxu94 commented on issue #39: Add command
`trace`
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #39: Add command `trace`
URL: https://github.com/apache/skywalking-cli/pull/39#issuecomment-605618790
[](https://asciinema.org/a/hmnVVAKQuRhPRrDOGxHFmroMC)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] kezhenxu94 commented on issue #39: Add command
`trace`
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #39: Add command `trace`
URL: https://github.com/apache/skywalking-cli/pull/39#issuecomment-605612662
> Cool, do you create an interactive tree? Could you post a youtube or jpg including the interaction, this is a good twitter and documentation material.
I can create one, soon
> Any new lib added for this?
No new lib for the trace tree, but a new lib for bundling the `*.graphql` files, which is `packr`, and I have added it into the `LICENSE` file, there's no `NOTICE` file in the `packr` project
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] codecov-io edited a comment on issue #39: Add
command `trace`
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #39: Add command `trace`
URL: https://github.com/apache/skywalking-cli/pull/39#issuecomment-605553208
# [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/39?src=pr&el=h1) Report
> Merging [#39](https://codecov.io/gh/apache/skywalking-cli/pull/39?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/cae9a72c017d6b72ff97803ed69b7c17adca7767&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking-cli/pull/39?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #39 +/- ##
=======================================
Coverage 57.14% 57.14%
=======================================
Files 7 7
Lines 112 112
=======================================
Hits 64 64
Misses 40 40
Partials 8 8
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/39?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/39?src=pr&el=footer). Last update [cae9a72...157341b](https://codecov.io/gh/apache/skywalking-cli/pull/39?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] kezhenxu94 commented on a change in pull request
#39: Add command `trace`
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #39: Add command `trace`
URL: https://github.com/apache/skywalking-cli/pull/39#discussion_r399740301
##########
File path: .graphqlconfig
##########
@@ -0,0 +1,11 @@
+{
+ "name": "SkyWalking GraphQL Schema",
+ "extensions": {
+ "endpoints": {
+ "SkyWalking GraphQL Endpoint": {
+ "url": "http://122.112.182.72:8080/graphql",
Review comment:
> I think this is an IP leak.
What do you mean by saying "leak", it's a public demo address
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] kezhenxu94 commented on issue #39: Add command
`trace`
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #39: Add command `trace`
URL: https://github.com/apache/skywalking-cli/pull/39#issuecomment-605554640
<img width="1439" alt="image" src="https://user-images.githubusercontent.com/15965696/77839890-ac2df880-71b3-11ea-8995-fe0fdadc8998.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] kezhenxu94 commented on a change in pull request
#39: Add command `trace`
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #39: Add command `trace`
URL: https://github.com/apache/skywalking-cli/pull/39#discussion_r399740321
##########
File path: .graphqlconfig
##########
@@ -0,0 +1,11 @@
+{
+ "name": "SkyWalking GraphQL Schema",
+ "extensions": {
+ "endpoints": {
+ "SkyWalking GraphQL Endpoint": {
+ "url": "http://122.112.182.72:8080/graphql",
Review comment:
Everyone who visits the main repo can get access to this address
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] wu-sheng commented on issue #39: Add command
`trace`
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #39: Add command `trace`
URL: https://github.com/apache/skywalking-cli/pull/39#issuecomment-605605922
Any new lib added for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services