You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/08/20 18:06:18 UTC
[GitHub] [incubator-pinot] jihaozh opened a new pull request #5903: [TE] anomalies page - fix feedback is not populated if retrived by the method findByIds
jihaozh opened a new pull request #5903:
URL: https://github.com/apache/incubator-pinot/pull/5903
Previously the anomaly feedback is not populated if retrieved by the method `findByIds`. This PR fixes the issue so that the feedbacks can be shown on the anomalies page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jihaozh commented on pull request #5903: [TE] anomalies page - fix feedback is not populated if retrived by the method findByIds
Posted by GitBox <gi...@apache.org>.
jihaozh commented on pull request #5903:
URL: https://github.com/apache/incubator-pinot/pull/5903#issuecomment-677959184
> Do you think that we should rename `findByIdList` to `findByIds`? I don't think that there is any usage of `findByIdList`
removed the legacy `findByIdList` method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jihaozh merged pull request #5903: [TE] anomalies page - fix feedback is not populated if retrived by the method findByIds
Posted by GitBox <gi...@apache.org>.
jihaozh merged pull request #5903:
URL: https://github.com/apache/incubator-pinot/pull/5903
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org