You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/05/25 22:49:09 UTC

[GitHub] [superset] michael-s-molina commented on pull request #14816: fix(native-filter): Default value multi-select height in native filters

michael-s-molina commented on pull request #14816:
URL: https://github.com/apache/superset/pull/14816#issuecomment-848318953


   > Thanks for the PR!
   > The reported issue is fixed, but we need to take care of the other issue "fixed height for select filter value box, so that multiple value select don't take up too much real estate in the filter bar". 
   > just repeating myself.. I'm ok to go with the ."...+4" solution as long as the selected filter value s are at the top when expand the list. please coordinate the fix with @michael-s-molina and @villebro 
   > 
   > https://user-images.githubusercontent.com/67837651/119574304-609cbd80-bd6a-11eb-919a-f050059816aa.mov
   > 
   > 
   > 
   > 
   @geido Thanks for the fix!
   
   @junlincc I'll add the select with +4 to my todo list. I will work on it right after we deliver the native filters revamp 😉


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org