You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@logging.apache.org by zsomborklara <gi...@git.apache.org> on 2017/09/29 10:37:46 UTC
[GitHub] logging-log4j2 pull request #111: LOG4J2-1216: Nested pattern layout options...
GitHub user zsomborklara opened a pull request:
https://github.com/apache/logging-log4j2/pull/111
LOG4J2-1216: Nested pattern layout options broken
Change is for the most part as suggested by the original reported of the issue in the Jira, I only added a unit test. I made one small modification:
```
if (depth > 0) { // option not closed, continue with pattern on opening "{"
return begin-1;
}
```
Turned to:
```
if (depth > 0) { // option not closed, continue with pattern after closing bracket
return pattern.indexOf('}', start) + 1;
}
```
Because the original version was breaking PatternParserTest#testCustomPattern.
Also it seems there are 3 unit test in core that are broken on head.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zsomborklara/logging-log4j2 master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/logging-log4j2/pull/111.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #111
----
commit 36919e2c72cfb88af5aca1ea4fd629b4bf5bac6d
Author: zsomborklara <zs...@cloudera.com>
Date: 2017-09-28T15:28:03Z
LOG4J2-1216: Nested pattern layout options broken
----
---
[GitHub] logging-log4j2 issue #111: LOG4J2-1216: Nested pattern layout options broken
Posted by mikaelstaldal <gi...@git.apache.org>.
Github user mikaelstaldal commented on the issue:
https://github.com/apache/logging-log4j2/pull/111
Is this PR still relevant? @garydgregory ?
---
[GitHub] logging-log4j2 issue #111: LOG4J2-1216: Nested pattern layout options broken
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/111
Reference: https://issues.apache.org/jira/browse/LOG4J2-1216
---
[GitHub] logging-log4j2 pull request #111: LOG4J2-1216: Nested pattern layout options...
Posted by zsomborklara <gi...@git.apache.org>.
Github user zsomborklara closed the pull request at:
https://github.com/apache/logging-log4j2/pull/111
---