You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "crepererum (via GitHub)" <gi...@apache.org> on 2025/06/16 10:18:43 UTC

[PR] refactor: `PutMultiPartOpts` => `PutMultiPartOptions` [arrow-rs-object-store]

crepererum opened a new pull request, #406:
URL: https://github.com/apache/arrow-rs-object-store/pull/406

   # Which issue does this PR close?
   See #339. (not closed, because old alias is still around)
   
   # Rationale for this change
   Consistency.
   
   # What changes are included in this PR?
   Rename.
   
   # Are there any user-facing changes?
   Users should use the new name, but the old name is kept as a deprecated alias for now.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor: `PutMultiPartOpts` => `PutMultiPartOptions` [arrow-rs-object-store]

Posted by "crepererum (via GitHub)" <gi...@apache.org>.
crepererum merged PR #406:
URL: https://github.com/apache/arrow-rs-object-store/pull/406


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor: `PutMultiPartOpts` => `PutMultiPartOptions` [arrow-rs-object-store]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #406:
URL: https://github.com/apache/arrow-rs-object-store/pull/406#issuecomment-2979860443

   FWIW I think we could also close the ticket (even though there is an alias) but I don't feel strongly
   - https://github.com/apache/arrow-rs-object-store/issues/339


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor: `PutMultiPartOpts` => `PutMultiPartOptions` [arrow-rs-object-store]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #406:
URL: https://github.com/apache/arrow-rs-object-store/pull/406#discussion_r2151936439


##########
src/lib.rs:
##########
@@ -1234,9 +1234,14 @@ impl From<Attributes> for PutOptions {
     }
 }
 
+// See <https://github.com/apache/arrow-rs-object-store/issues/339>.
+#[doc(hidden)]
+#[deprecated(note = "Use PutMultipartOptions")]

Review Comment:
   Can we also please add an `since` annotation so we know in the future when to remove this? 
   
   For example like this
   https://github.com/apache/arrow-rs/blob/639b5bb93e5a152a437b93a25ead8095a3866a9b/parquet/src/file/footer.rs#L47
   
   I believe it will be released in `0.13.0`:
   - https://github.com/apache/arrow-rs-object-store/issues/367



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor: `PutMultiPartOpts` => `PutMultiPartOptions` [arrow-rs-object-store]

Posted by "crepererum (via GitHub)" <gi...@apache.org>.
crepererum commented on code in PR #406:
URL: https://github.com/apache/arrow-rs-object-store/pull/406#discussion_r2151965117


##########
src/lib.rs:
##########
@@ -1234,9 +1234,14 @@ impl From<Attributes> for PutOptions {
     }
 }
 
+// See <https://github.com/apache/arrow-rs-object-store/issues/339>.
+#[doc(hidden)]
+#[deprecated(note = "Use PutMultipartOptions")]

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org