Re: Clam AntiVirus plugin for SpamAssassin 3.x

[Justin Mason <jm...@jmason.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Troels Walsted Hansen writes:
> Daryl C. W. O'Shea wrote:
> 
> > Well sort of.  The headers only get set if the message ends up being 
> > classified as spam.  If you receive a virus from a whitelisted user, or 
> > in a message that would otherwise score less than -5.0 (at least with 
> > the default score CLAMAV 10), the X-Spam-Virus: Yes ($virus) header 
> > won't be added since the headers are only added to %headers_spam.  Of 
> > course, clean messages won't have a header added in ham messages either.
> > 
> > Adding the "Virus" headers to the headers_ham hash, as in the attached 
> > file, correct this.
> 
> You're perfectly right, of course. I did notice this problem, but I
> wasn't aware of headers_ham so I didn't find a way to fix it. In fact I
> was wondering about the legality of manipulating
> $permsgstatus->{main}->{conf} from a plugin. Is it considered bad practice?
> 
> I was expecting a $permsgstatus->add_header() function or similar, and
> when I didn't find I grepped the SA source until I found an alternative
> way to add headers to the mail.
> 
> Thanks for your fix!

This is definitely an interesting feature idea.  Could you open a bug
on the bugzilla for that?

Also, putting the plugin code into the Wiki would be great ;)  There's
a CustomPlugins page, iirc.

> > Otherwise a pretty cool plugin for those who can't for whatever reason 
> > do it another way.
> 
> Thank you.
> 
> Troels
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Exmh CVS

iD8DBQFBkoGMMJF5cimLx9ARAhaFAKCuOPx452TTmRB7/lgM5QSOrdtYcgCfRogD
PvulDnCbe6kDRztv/L6Nnw4=
=L2OG
-----END PGP SIGNATURE-----

Re: Clam AntiVirus plugin for SpamAssassin 3.x

[Troels Walsted Hansen <tr...@thule.no>]

Justin Mason wrote:

>>I was expecting a $permsgstatus->add_header() function or similar, and
>>when I didn't find I grepped the SA source until I found an alternative
>>way to add headers to the mail.
>>    
>>
>This is definitely an interesting feature idea.  Could you open a bug
>on the bugzilla for that?
>  
>
I was going to, but then I found Bug #3389: "Request for ability to add 
arbitrary headers from plugins" 
<http://bugzilla.spamassassin.org/show_bug.cgi?id=3389>

I think that covers it pretty well..?

>Also, putting the plugin code into the Wiki would be great ;)  There's
>a CustomPlugins page, iirc.
>  
>
Will do.

Troels