You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/07/04 00:45:43 UTC
[GitHub] [nifi] ottobackwards opened a new pull request #4384: NIFI-2702 Support named captures in ExtractText
ottobackwards opened a new pull request #4384:
URL: https://github.com/apache/nifi/pull/4384
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
Enables ExtractText to support creating attributes named by named group captures.
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [x] Have you written or updated unit tests to verify your changes?
- [x] Have you verified that the full build is successful on JDK 8?
- [-] Have you verified that the full build is successful on JDK 11?
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [-] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [-] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [x] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x ] Have you ensured that format looks appropriate for the output in which it is rendered?
NOTE: the original did not look great. This is equally as bad.
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #4384: NIFI-2072 Support named captures in ExtractText
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on pull request #4384:
URL: https://github.com/apache/nifi/pull/4384#issuecomment-701255032
Hey @ottobackwards - I just went through this PR and it LGTM. Given that the processor becomes a little bit more "complex", I think it'd make a lot of sense to have an ``additionalDetails.html`` page for this processor with examples and explanations on how this processor works based on all the properties and the different combinations. Do you mind taking a look at this as part of this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on a change in pull request #4384: NIFI-2702 Support named captures in ExtractText
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on a change in pull request #4384:
URL: https://github.com/apache/nifi/pull/4384#discussion_r449724719
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestExtractTextNamedGroups.java
##########
@@ -0,0 +1,383 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
Review comment:
The same tests related to capture from TestExtractText,
Although adapted to the difference in output
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on a change in pull request #4384: NIFI-2702 Support named captures in ExtractText
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on a change in pull request #4384:
URL: https://github.com/apache/nifi/pull/4384#discussion_r449724719
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestExtractTextNamedGroups.java
##########
@@ -0,0 +1,383 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
Review comment:
The same tests related to capture from TestExtractText
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards closed pull request #4384: NIFI-2072 Support named captures in ExtractText
Posted by GitBox <gi...@apache.org>.
ottobackwards closed pull request #4384:
URL: https://github.com/apache/nifi/pull/4384
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #4384: NIFI-2072 Support named captures in ExtractText
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on pull request #4384:
URL: https://github.com/apache/nifi/pull/4384#issuecomment-797314527
Merged to main, thanks @ottobackwards and sorry for the delay.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on a change in pull request #4384: NIFI-2702 Support named captures in ExtractText
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on a change in pull request #4384:
URL: https://github.com/apache/nifi/pull/4384#discussion_r450276914
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractText.java
##########
@@ -69,14 +71,26 @@
+ "The results of those Regular Expressions are assigned to FlowFile Attributes. "
+ "Regular Expressions are entered by adding user-defined properties; "
+ "the name of the property maps to the Attribute Name into which the result will be placed. "
+ + "The attributes are generated differently based on the enablement of named capture groups. "
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on pull request #4384: NIFI-2072 Support named captures in ExtractText
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #4384:
URL: https://github.com/apache/nifi/pull/4384#issuecomment-797466324
Thanks @pvillard31 , also thank you @malthe!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on pull request #4384: NIFI-2072 Support named captures in ExtractText
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #4384:
URL: https://github.com/apache/nifi/pull/4384#issuecomment-796747905
Wakey Wakey
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on pull request #4384: NIFI-2702 Support named captures in ExtractText
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #4384:
URL: https://github.com/apache/nifi/pull/4384#issuecomment-655106630
updated the base to `main`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on pull request #4384: NIFI-2072 Support named captures in ExtractText
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #4384:
URL: https://github.com/apache/nifi/pull/4384#issuecomment-674968508
Now that the release is out, maybe we can get some action on this? @pvillard31? @malthe
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on pull request #4384: NIFI-2072 Support named captures in ExtractText
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #4384:
URL: https://github.com/apache/nifi/pull/4384#issuecomment-700973513
touch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #4384: NIFI-2072 Support named captures in ExtractText
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on pull request #4384:
URL: https://github.com/apache/nifi/pull/4384#issuecomment-760157271
Hey @ottobackwards - I'll try to go through it before the end of the week... but, truth be told, it's unlikely that I'll find time to merge this in soon, too many things on my plate right now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] malthe commented on a change in pull request #4384: NIFI-2702 Support named captures in ExtractText
Posted by GitBox <gi...@apache.org>.
malthe commented on a change in pull request #4384:
URL: https://github.com/apache/nifi/pull/4384#discussion_r450028255
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractText.java
##########
@@ -69,14 +71,26 @@
+ "The results of those Regular Expressions are assigned to FlowFile Attributes. "
+ "Regular Expressions are entered by adding user-defined properties; "
+ "the name of the property maps to the Attribute Name into which the result will be placed. "
+ + "The attributes are generated differently based on the enablement of named capture groups. "
Review comment:
Enabling?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #4384: NIFI-2072 Support named captures in ExtractText
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4384:
URL: https://github.com/apache/nifi/pull/4384
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on pull request #4384: NIFI-2072 Support named captures in ExtractText
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #4384:
URL: https://github.com/apache/nifi/pull/4384#issuecomment-759470864
@pvillard31 it would be nice to get this to 1.13.0 and not make the requestor wait another release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on a change in pull request #4384: NIFI-2702 Support named captures in ExtractText
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on a change in pull request #4384:
URL: https://github.com/apache/nifi/pull/4384#discussion_r449724622
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractText.java
##########
@@ -16,6 +16,8 @@
*/
package org.apache.nifi.processors.standard;
Review comment:
This is already included in the car
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractText.java
##########
@@ -16,6 +16,8 @@
*/
package org.apache.nifi.processors.standard;
Review comment:
This is already included in the nar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on a change in pull request #4384: NIFI-2702 Support named captures in ExtractText
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on a change in pull request #4384:
URL: https://github.com/apache/nifi/pull/4384#discussion_r449724719
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestExtractTextNamedGroups.java
##########
@@ -0,0 +1,383 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
Review comment:
The same tests related to capture from TestExtractText,
Although adapted to the difference input and output
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on pull request #4384: NIFI-2072 Support named captures in ExtractText
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #4384:
URL: https://github.com/apache/nifi/pull/4384#issuecomment-701315803
That sounds reasonable. I'll do that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on pull request #4384: NIFI-2072 Support named captures in ExtractText
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #4384:
URL: https://github.com/apache/nifi/pull/4384#issuecomment-760161695
@pvillard31 that is perfectly fine. I picked this out of jira to hack on, and there has been user engagement, so I just wanted to advocate for it as best I could.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on pull request #4384: NIFI-2072 Support named captures in ExtractText
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #4384:
URL: https://github.com/apache/nifi/pull/4384#issuecomment-760164733
I'll say that I'm a better technical documentation editor than author
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on pull request #4384: NIFI-2072 Support named captures in ExtractText
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #4384:
URL: https://github.com/apache/nifi/pull/4384#issuecomment-754007304
Happy New Year!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org