[GitHub] [trafficcontrol] rob05c commented on issue #4303: Updated GetDeliveryServiceByXMLID function to return a DS nullable struct

[GitBox <gi...@apache.org>]

rob05c commented on issue #4303: Updated GetDeliveryServiceByXMLID function to return a DS nullable struct
URL: https://github.com/apache/trafficcontrol/pull/4303#issuecomment-575224825
 
 
   Yeah, like @ocket8888 says, this will break existing things, but it also breaks the stability of the Go library, and it will fundamentally break Go Modules if and when we switch to them (which we'll probably have to at some point).
   
   The way we've typically done this in the past is to add a new function with a similar name, e.g. `DeliveryServiceByXMLID` or `GetDeliveryServiceByXMLIDNullable`, and add a Deprecated comment to the old one.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services