You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/05 17:22:10 UTC
[GitHub] [superset] eschutho commented on a change in pull request #13946: fix: SQL -> Explore Overwrite flow
eschutho commented on a change in pull request #13946:
URL: https://github.com/apache/superset/pull/13946#discussion_r607214397
##########
File path: tests/datasets/api_tests.py
##########
@@ -598,12 +598,7 @@ def test_update_dataset_item_w_override_columns(self):
rv = self.put_assert_metric(uri, dataset_data, "put")
assert rv.status_code == 200
- columns = (
- db.session.query(TableColumn)
- .filter_by(table_id=dataset.id)
- .order_by("column_name")
- .all()
- )
+ columns = db.session.query(TableColumn).filter_by(table_id=dataset.id).all()
Review comment:
we're removing the ordering in the tests? Was it failing with the order/
##########
File path: tests/datasets/api_tests.py
##########
@@ -598,12 +598,7 @@ def test_update_dataset_item_w_override_columns(self):
rv = self.put_assert_metric(uri, dataset_data, "put")
assert rv.status_code == 200
- columns = (
- db.session.query(TableColumn)
- .filter_by(table_id=dataset.id)
- .order_by("column_name")
- .all()
- )
+ columns = db.session.query(TableColumn).filter_by(table_id=dataset.id).all()
Review comment:
we're removing the ordering in the tests? Was it failing with the order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org