[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #1489: Add Redis-compatible cursors for `SCAN` commands

["git-hulk (via GitHub)" <gi...@apache.org>]

git-hulk commented on code in PR #1489:
URL: https://github.com/apache/incubator-kvrocks/pull/1489#discussion_r1233548929


##########
kvrocks.conf:
##########
@@ -296,6 +296,12 @@ max-backup-keep-hours 24
 # Default: 16
 max-bitmap-to-string-mb 16
 
+# Whether to enable SCAN, HSCAN, SSCAN, ZSCAN cursor redis compatibility mode. 
+# If enabled, the cursor will be unsigned 64-bit integers.
+# If disable, the cursor will be string.
+# Default: yes
+redis-cursor-compatible yes

Review Comment:
   ```suggestion
   # If enabled, the cursor will be unsigned 64-bit integers.
   # If disabled, the cursor will be a string.
   # Default: yes
   redis-cursor-compatible yes
   ```



##########
src/config/config.cc:
##########
@@ -165,6 +165,7 @@ Config::Config() {
       {"unixsocketperm", true, new OctalField(&unixsocketperm, 0777, 1, INT_MAX)},
       {"log-retention-days", false, new IntField(&log_retention_days, -1, -1, INT_MAX)},
       {"persist-cluster-nodes-enabled", false, new YesNoField(&persist_cluster_nodes_enabled, true)},
+      {"redis-cursor-compatible", false, new YesNoField(&redis_cursor_compatible, true)},

Review Comment:
   The default value should be false to avoid breaking the old behavior.



##########
kvrocks.conf:
##########
@@ -296,6 +296,12 @@ max-backup-keep-hours 24
 # Default: 16
 max-bitmap-to-string-mb 16
 
+# Whether to enable SCAN, HSCAN, SSCAN, ZSCAN cursor redis compatibility mode. 
+# If enabled, the cursor will be unsigned 64-bit integers.
+# If disable, the cursor will be string.
+# Default: yes
+number-cursor-enabled yes
+

Review Comment:
   ```suggestion
   # Whether to enable SCAN, HSCAN, SSCAN, ZSCAN cursor redis compatibility mode. 
   # If enabled, the cursor will be unsigned 64-bit integers.
   # If disabled, the cursor will be a string.
   # Default: yes
   number-cursor-enabled yes
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org