You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Omega359 (via GitHub)" <gi...@apache.org> on 2024/05/23 14:33:59 UTC
[PR] Update cli Dockerfile to a newer ubuntu release, newer rust release [datafusion]
Omega359 opened a new pull request, #10638:
URL: https://github.com/apache/datafusion/pull/10638
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #10472
## Rationale for this change
The current Dockerfile is based on a pretty old ubuntu release which doesn't build when run on a newer ubuntu release. I can see no good reason why the cli should be built using old ubuntu and rust versions.
## What changes are included in this PR?
Dockerfile update.
## Are these changes tested?
Built and tested locally on wsl2/ubuntyu 22.04.4
## Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Update cli Dockerfile to a newer ubuntu release, newer rust release [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #10638:
URL: https://github.com/apache/datafusion/pull/10638#discussion_r1613016952
##########
datafusion-cli/Dockerfile:
##########
@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
-FROM rust:1.73-bullseye as builder
+FROM rust:1.78-bookworm as builder
Review Comment:
> The Rust version update is only for the build of the CLI. Nothing more. It's not related to the MSRV of DataFusion unless the build of the CLI is the litmus test that the MSRV we have actually builds and runs.
I think the MSRV is verified via a CI job: https://github.com/apache/datafusion/blob/4b7b5ab11a868c0069245f411f0d9b08e1b2744e/.github/workflows/rust.yml#L556-L584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Update cli Dockerfile to a newer ubuntu release, newer rust release [datafusion]
Posted by "edmondop (via GitHub)" <gi...@apache.org>.
edmondop commented on code in PR #10638:
URL: https://github.com/apache/datafusion/pull/10638#discussion_r1612203716
##########
datafusion-cli/Dockerfile:
##########
@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
-FROM rust:1.73-bullseye as builder
+FROM rust:1.78-bookworm as builder
Review Comment:
The workspace.package in the `Cargo.toml` is still 1.73. https://github.com/apache/datafusion/blob/main/Cargo.toml#L53
I am fine with updating the Debian version, but updating the Rust version might require more thoughts or having more extensive implications cc @alamb @andygrove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Update cli Dockerfile to a newer ubuntu release, newer rust release [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #10638:
URL: https://github.com/apache/datafusion/pull/10638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Update cli Dockerfile to a newer ubuntu release, newer rust release [datafusion]
Posted by "Omega359 (via GitHub)" <gi...@apache.org>.
Omega359 closed pull request #10638: Update cli Dockerfile to a newer ubuntu release, newer rust release
URL: https://github.com/apache/datafusion/pull/10638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Update cli Dockerfile to a newer ubuntu release, newer rust release [datafusion]
Posted by "Omega359 (via GitHub)" <gi...@apache.org>.
Omega359 commented on code in PR #10638:
URL: https://github.com/apache/datafusion/pull/10638#discussion_r1612224719
##########
datafusion-cli/Dockerfile:
##########
@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
-FROM rust:1.73-bullseye as builder
+FROM rust:1.78-bookworm as builder
Review Comment:
The Rust version update is only for the build of the CLI. Nothing more. It's not related to the MSRV of DataFusion unless the build of the CLI is the litmus test that the MSRV we have actually builds and runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org