You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@arrow.apache.org by Wes McKinney <we...@gmail.com> on 2018/09/29 08:56:40 UTC
Re: [RESULT] [VOTE] Accept donation of Gandiva to Apache Arrow
The merge has just been completed.
There have been about 11 patches to the old Gandiva repo since
beginning the merge and IP clearance process. I'm a bit unclear how to
proceed as it appears to be a substantial amount of additional work
developed outside of the community. Advice from others would be
appreciated.
https://github.com/dremio/gandiva/commits/master
On Tue, Aug 21, 2018 at 12:56 PM Wes McKinney <we...@gmail.com> wrote:
>
> The vote carries with 7 binding +1 votes and 4 non-binding +1
>
> We look forward to working with the Gandiva developers on the code
> donation process
>
> On Sat, Aug 18, 2018 at 11:09 PM, Uwe L. Korn <uw...@xhochy.com> wrote:
> > +1
> >
> > Uwe
> >
> > On Fri, Aug 17, 2018, at 5:02 AM, Jeff Zhang wrote:
> >> +1
> >>
> >> Phillip Cloud <cp...@gmail.com>于2018年8月17日周五 上午10:59写道：
> >>
> >> > +1
> >> >
> >> > On Thu, Aug 16, 2018 at 9:26 PM Andy Grove <an...@gmail.com> wrote:
> >> >
> >> > > +1
> >> > >
> >> > > On Thu, Aug 16, 2018 at 9:56 AM Wes McKinney <we...@gmail.com>
> >> > wrote:
> >> > >
> >> > > > Dear all,
> >> > > >
> >> > > > The developers of Gandiva, an LLVM-based vectorized expression
> >> > > > evaluation engine for Arrow columnar memory, are proposing to donate
> >> > > > the project to Apache Arrow at some point in the near future, as has
> >> > > > been discussed on the dev@ mailing list [1].
> >> > > >
> >> > > > The Gandiva codebase is located at:
> >> > > >
> >> > > > https://github.com/dremio/gandiva
> >> > > >
> >> > > > This work is not yet in a patch-ready state, but I wish to determine
> >> > > > if the Arrow PMC is in favor of accepting this donation, subject to
> >> > > > the fulfillment of the ASF IP Clearance process.
> >> > > >
> >> > > > [ ] +1 : Accept contribution of Gandiva
> >> > > > [ ] 0 : No opinion
> >> > > > [ ] -1 : Reject contribution because...
> >> > > >
> >> > > > Here is my vote: +1
> >> > > >
> >> > > > The vote will be open for at least 72 hours.
> >> > > >
> >> > > > Thanks,
> >> > > > Wes
> >> > > >
> >> > > > [1]:
> >> > > >
> >> > >
> >> > https://lists.apache.org/thread.html/cded0b511c68da21246cd25e99b4ad77092d17219629f73e0dc85cad@%3Cdev.arrow.apache.org%3E
> >> > > >
> >> > >
> >> >
Re: [RESULT] [VOTE] Accept donation of Gandiva to Apache Arrow
Posted by Praveen Kumar <pr...@dremio.com>.
Hi Wes,
Thanks for all the help in getting us merged with the apache/arrow repo.
Sorry we lost track of this in the last couple weeks.
The following are the pending items for the gandiva code in the arrow repo
1. Include gandiva-cpp in Travis CI.
2. Include gandiva-java Travis CI.
3. Synchronize the repositories with the remaining work on gandiva.
4. Deployment support for gandiva snapshot versions that contains the
packaged library.
5. Packaging support for other OS, today we only package a .so, would need
a dylib and dll in future.
I am creating separate jiras for each of the items, plan is to work on them
from October 3.
Thx.
On Sat, Sep 29, 2018 at 4:22 PM Wes McKinney <we...@gmail.com> wrote:
> If you could put all the outstanding patches in a PR for us to take a
> look we can bring those in. I'm available and working all weekend if
> you want to try to get the repo synchronized, so you could move your
> outstanding PRs over and have your development process continue in the
> Apache community. Continuing to develop and have code reviews in an
> external repo is problematic from an ASF point of view at this point.
>
> Let me know if I can help -- I am available at short notice.
>
> Thanks,
> Wes
> On Sat, Sep 29, 2018 at 6:48 AM Praveen Kumar <pr...@dremio.com> wrote:
> >
> > Thanks Wes. Since we already have submitted the ICLAs, is it ok if we
> > submit them as combined PRs for the remaining work?
> >
> > We might still have a couple more PRs to the old repo before we stop
> > development there.
> >
> > On Sat, Sep 29, 2018 at 2:27 PM Wes McKinney <we...@gmail.com>
> wrote:
> >
> > > The merge has just been completed.
> > >
> > > There have been about 11 patches to the old Gandiva repo since
> > > beginning the merge and IP clearance process. I'm a bit unclear how to
> > > proceed as it appears to be a substantial amount of additional work
> > > developed outside of the community. Advice from others would be
> > > appreciated.
> > >
> > > https://github.com/dremio/gandiva/commits/master
> > > On Tue, Aug 21, 2018 at 12:56 PM Wes McKinney <we...@gmail.com>
> wrote:
> > > >
> > > > The vote carries with 7 binding +1 votes and 4 non-binding +1
> > > >
> > > > We look forward to working with the Gandiva developers on the code
> > > > donation process
> > > >
> > > > On Sat, Aug 18, 2018 at 11:09 PM, Uwe L. Korn <uw...@xhochy.com>
> wrote:
> > > > > +1
> > > > >
> > > > > Uwe
> > > > >
> > > > > On Fri, Aug 17, 2018, at 5:02 AM, Jeff Zhang wrote:
> > > > >> +1
> > > > >>
> > > > >> Phillip Cloud <cp...@gmail.com>于2018年8月17日周五 上午10:59写道：
> > > > >>
> > > > >> > +1
> > > > >> >
> > > > >> > On Thu, Aug 16, 2018 at 9:26 PM Andy Grove <
> andygrove73@gmail.com>
> > > wrote:
> > > > >> >
> > > > >> > > +1
> > > > >> > >
> > > > >> > > On Thu, Aug 16, 2018 at 9:56 AM Wes McKinney <
> wesmckinn@gmail.com
> > > >
> > > > >> > wrote:
> > > > >> > >
> > > > >> > > > Dear all,
> > > > >> > > >
> > > > >> > > > The developers of Gandiva, an LLVM-based vectorized
> expression
> > > > >> > > > evaluation engine for Arrow columnar memory, are proposing
> to
> > > donate
> > > > >> > > > the project to Apache Arrow at some point in the near
> future,
> > > as has
> > > > >> > > > been discussed on the dev@ mailing list [1].
> > > > >> > > >
> > > > >> > > > The Gandiva codebase is located at:
> > > > >> > > >
> > > > >> > > > https://github.com/dremio/gandiva
> > > > >> > > >
> > > > >> > > > This work is not yet in a patch-ready state, but I wish to
> > > determine
> > > > >> > > > if the Arrow PMC is in favor of accepting this donation,
> > > subject to
> > > > >> > > > the fulfillment of the ASF IP Clearance process.
> > > > >> > > >
> > > > >> > > > [ ] +1 : Accept contribution of Gandiva
> > > > >> > > > [ ] 0 : No opinion
> > > > >> > > > [ ] -1 : Reject contribution because...
> > > > >> > > >
> > > > >> > > > Here is my vote: +1
> > > > >> > > >
> > > > >> > > > The vote will be open for at least 72 hours.
> > > > >> > > >
> > > > >> > > > Thanks,
> > > > >> > > > Wes
> > > > >> > > >
> > > > >> > > > [1]:
> > > > >> > > >
> > > > >> > >
> > > > >> >
> > >
> https://lists.apache.org/thread.html/cded0b511c68da21246cd25e99b4ad77092d17219629f73e0dc85cad@%3Cdev.arrow.apache.org%3E
> > > > >> > > >
> > > > >> > >
> > > > >> >
> > >
>
Re: [RESULT] [VOTE] Accept donation of Gandiva to Apache Arrow
Posted by Wes McKinney <we...@gmail.com>.
If you could put all the outstanding patches in a PR for us to take a
look we can bring those in. I'm available and working all weekend if
you want to try to get the repo synchronized, so you could move your
outstanding PRs over and have your development process continue in the
Apache community. Continuing to develop and have code reviews in an
external repo is problematic from an ASF point of view at this point.
Let me know if I can help -- I am available at short notice.
Thanks,
Wes
On Sat, Sep 29, 2018 at 6:48 AM Praveen Kumar <pr...@dremio.com> wrote:
>
> Thanks Wes. Since we already have submitted the ICLAs, is it ok if we
> submit them as combined PRs for the remaining work?
>
> We might still have a couple more PRs to the old repo before we stop
> development there.
>
> On Sat, Sep 29, 2018 at 2:27 PM Wes McKinney <we...@gmail.com> wrote:
>
> > The merge has just been completed.
> >
> > There have been about 11 patches to the old Gandiva repo since
> > beginning the merge and IP clearance process. I'm a bit unclear how to
> > proceed as it appears to be a substantial amount of additional work
> > developed outside of the community. Advice from others would be
> > appreciated.
> >
> > https://github.com/dremio/gandiva/commits/master
> > On Tue, Aug 21, 2018 at 12:56 PM Wes McKinney <we...@gmail.com> wrote:
> > >
> > > The vote carries with 7 binding +1 votes and 4 non-binding +1
> > >
> > > We look forward to working with the Gandiva developers on the code
> > > donation process
> > >
> > > On Sat, Aug 18, 2018 at 11:09 PM, Uwe L. Korn <uw...@xhochy.com> wrote:
> > > > +1
> > > >
> > > > Uwe
> > > >
> > > > On Fri, Aug 17, 2018, at 5:02 AM, Jeff Zhang wrote:
> > > >> +1
> > > >>
> > > >> Phillip Cloud <cp...@gmail.com>于2018年8月17日周五 上午10:59写道：
> > > >>
> > > >> > +1
> > > >> >
> > > >> > On Thu, Aug 16, 2018 at 9:26 PM Andy Grove <an...@gmail.com>
> > wrote:
> > > >> >
> > > >> > > +1
> > > >> > >
> > > >> > > On Thu, Aug 16, 2018 at 9:56 AM Wes McKinney <wesmckinn@gmail.com
> > >
> > > >> > wrote:
> > > >> > >
> > > >> > > > Dear all,
> > > >> > > >
> > > >> > > > The developers of Gandiva, an LLVM-based vectorized expression
> > > >> > > > evaluation engine for Arrow columnar memory, are proposing to
> > donate
> > > >> > > > the project to Apache Arrow at some point in the near future,
> > as has
> > > >> > > > been discussed on the dev@ mailing list [1].
> > > >> > > >
> > > >> > > > The Gandiva codebase is located at:
> > > >> > > >
> > > >> > > > https://github.com/dremio/gandiva
> > > >> > > >
> > > >> > > > This work is not yet in a patch-ready state, but I wish to
> > determine
> > > >> > > > if the Arrow PMC is in favor of accepting this donation,
> > subject to
> > > >> > > > the fulfillment of the ASF IP Clearance process.
> > > >> > > >
> > > >> > > > [ ] +1 : Accept contribution of Gandiva
> > > >> > > > [ ] 0 : No opinion
> > > >> > > > [ ] -1 : Reject contribution because...
> > > >> > > >
> > > >> > > > Here is my vote: +1
> > > >> > > >
> > > >> > > > The vote will be open for at least 72 hours.
> > > >> > > >
> > > >> > > > Thanks,
> > > >> > > > Wes
> > > >> > > >
> > > >> > > > [1]:
> > > >> > > >
> > > >> > >
> > > >> >
> > https://lists.apache.org/thread.html/cded0b511c68da21246cd25e99b4ad77092d17219629f73e0dc85cad@%3Cdev.arrow.apache.org%3E
> > > >> > > >
> > > >> > >
> > > >> >
> >
Re: [RESULT] [VOTE] Accept donation of Gandiva to Apache Arrow
Posted by Praveen Kumar <pr...@dremio.com>.
Thanks Wes. Since we already have submitted the ICLAs, is it ok if we
submit them as combined PRs for the remaining work?
We might still have a couple more PRs to the old repo before we stop
development there.
On Sat, Sep 29, 2018 at 2:27 PM Wes McKinney <we...@gmail.com> wrote:
> The merge has just been completed.
>
> There have been about 11 patches to the old Gandiva repo since
> beginning the merge and IP clearance process. I'm a bit unclear how to
> proceed as it appears to be a substantial amount of additional work
> developed outside of the community. Advice from others would be
> appreciated.
>
> https://github.com/dremio/gandiva/commits/master
> On Tue, Aug 21, 2018 at 12:56 PM Wes McKinney <we...@gmail.com> wrote:
> >
> > The vote carries with 7 binding +1 votes and 4 non-binding +1
> >
> > We look forward to working with the Gandiva developers on the code
> > donation process
> >
> > On Sat, Aug 18, 2018 at 11:09 PM, Uwe L. Korn <uw...@xhochy.com> wrote:
> > > +1
> > >
> > > Uwe
> > >
> > > On Fri, Aug 17, 2018, at 5:02 AM, Jeff Zhang wrote:
> > >> +1
> > >>
> > >> Phillip Cloud <cp...@gmail.com>于2018年8月17日周五 上午10:59写道：
> > >>
> > >> > +1
> > >> >
> > >> > On Thu, Aug 16, 2018 at 9:26 PM Andy Grove <an...@gmail.com>
> wrote:
> > >> >
> > >> > > +1
> > >> > >
> > >> > > On Thu, Aug 16, 2018 at 9:56 AM Wes McKinney <wesmckinn@gmail.com
> >
> > >> > wrote:
> > >> > >
> > >> > > > Dear all,
> > >> > > >
> > >> > > > The developers of Gandiva, an LLVM-based vectorized expression
> > >> > > > evaluation engine for Arrow columnar memory, are proposing to
> donate
> > >> > > > the project to Apache Arrow at some point in the near future,
> as has
> > >> > > > been discussed on the dev@ mailing list [1].
> > >> > > >
> > >> > > > The Gandiva codebase is located at:
> > >> > > >
> > >> > > > https://github.com/dremio/gandiva
> > >> > > >
> > >> > > > This work is not yet in a patch-ready state, but I wish to
> determine
> > >> > > > if the Arrow PMC is in favor of accepting this donation,
> subject to
> > >> > > > the fulfillment of the ASF IP Clearance process.
> > >> > > >
> > >> > > > [ ] +1 : Accept contribution of Gandiva
> > >> > > > [ ] 0 : No opinion
> > >> > > > [ ] -1 : Reject contribution because...
> > >> > > >
> > >> > > > Here is my vote: +1
> > >> > > >
> > >> > > > The vote will be open for at least 72 hours.
> > >> > > >
> > >> > > > Thanks,
> > >> > > > Wes
> > >> > > >
> > >> > > > [1]:
> > >> > > >
> > >> > >
> > >> >
> https://lists.apache.org/thread.html/cded0b511c68da21246cd25e99b4ad77092d17219629f73e0dc85cad@%3Cdev.arrow.apache.org%3E
> > >> > > >
> > >> > >
> > >> >
>