You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/08/25 05:48:47 UTC

[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #3326: [KYUUBI #3325] [FEATURE] [AUTHZ] Privilege checks for permanent views and skipping shadowed tables

yaooqinn commented on code in PR #3326:
URL: https://github.com/apache/incubator-kyuubi/pull/3326#discussion_r954525881


##########
extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/util/AuthZUtils.scala:
##########
@@ -98,6 +98,20 @@ private[authz] object AuthZUtils {
     }
   }
 
+  def isPermanentView(plan: LogicalPlan): Boolean = {

Review Comment:
   Let's rename it to hasResolvedPermanentView here? and check resolved?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org