You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Peter Rozsa (Code Review)" <ge...@cloudera.org> on 2026/07/08 14:11:23 UTC
[Impala-ASF-CR] IMPALA-15151: Set Java source version to 17
Peter Rozsa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24561
Change subject: IMPALA-15151: Set Java source version to 17
......................................................................
IMPALA-15151: Set Java source version to 17
Bump maven.compiler.source from 8 to 17 in java/pom.xml.
sun.misc.Unsafe was explicitly exempted from strong encapsulation in
Java 17 (JEP 260, JEP 403), so it remains accessible without
--add-exports.
Change-Id: Iccb7b9cc28ad8ade554298503f2d8f4dee789151
Assisted-by: Claude Sonnet 4.6 (OpenCode)
---
M java/pom.xml
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/24561/1
--
To view, visit http://gerrit.cloudera.org:8080/24561
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iccb7b9cc28ad8ade554298503f2d8f4dee789151
Gerrit-Change-Number: 24561
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-15151: Set Java source version to 17
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24561 )
Change subject: IMPALA-15151: Set Java source version to 17
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24561
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iccb7b9cc28ad8ade554298503f2d8f4dee789151
Gerrit-Change-Number: 24561
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Jul 2026 17:21:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15151: Set Java source version to 17
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24561 )
Change subject: IMPALA-15151: Set Java source version to 17
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13710/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/24561
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iccb7b9cc28ad8ade554298503f2d8f4dee789151
Gerrit-Change-Number: 24561
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Jul 2026 14:12:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15151: Set Java source version to 17
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24561 )
Change subject: IMPALA-15151: Set Java source version to 17
......................................................................
Patch Set 1:
(1 comment)
> Patch Set 1:
>
> (1 comment)
>
> Works for me.
http://gerrit.cloudera.org:8080/#/c/24561/1/java/pom.xml
File java/pom.xml:
http://gerrit.cloudera.org:8080/#/c/24561/1/java/pom.xml@95
PS1, Line 95: <maven.compiler.source>17</maven.compiler.source>
> We should switch to using maven.compiler.release instead of separate maven.
If we use maven.compiler.release, then we can't use --add-exports for the unsafe package. To use it, first, we have to do a port for our UnsafeUtil to FFM but FFM is incubating in Java 17. To ultimately resolve this situation, we have to move to Java 21. I'd keep source/target as of now.
--
To view, visit http://gerrit.cloudera.org:8080/24561
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iccb7b9cc28ad8ade554298503f2d8f4dee789151
Gerrit-Change-Number: 24561
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Jul 2026 09:06:04 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-15151: Set Java source version to 17
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24561 )
Change subject: IMPALA-15151: Set Java source version to 17
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/24561/1/java/pom.xml
File java/pom.xml:
http://gerrit.cloudera.org:8080/#/c/24561/1/java/pom.xml@95
PS1, Line 95: <maven.compiler.source>17</maven.compiler.source>
> If we use maven.compiler.release, then we can't use --add-exports for the u
Ack
--
To view, visit http://gerrit.cloudera.org:8080/24561
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iccb7b9cc28ad8ade554298503f2d8f4dee789151
Gerrit-Change-Number: 24561
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Jul 2026 16:01:22 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-15151: Set Java source version to 17
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24561 )
Change subject: IMPALA-15151: Set Java source version to 17
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/24561
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iccb7b9cc28ad8ade554298503f2d8f4dee789151
Gerrit-Change-Number: 24561
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Jul 2026 18:41:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15151: Set Java source version to 17
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24561 )
Change subject: IMPALA-15151: Set Java source version to 17
......................................................................
Patch Set 1:
(1 comment)
Works for me.
http://gerrit.cloudera.org:8080/#/c/24561/1/java/pom.xml
File java/pom.xml:
http://gerrit.cloudera.org:8080/#/c/24561/1/java/pom.xml@95
PS1, Line 95: <maven.compiler.source>17</maven.compiler.source>
We should switch to using maven.compiler.release instead of separate maven.compiler.{source/target}.
--
To view, visit http://gerrit.cloudera.org:8080/24561
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iccb7b9cc28ad8ade554298503f2d8f4dee789151
Gerrit-Change-Number: 24561
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Jul 2026 16:35:59 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-15151: Set Java source version to 17
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24561 )
Change subject: IMPALA-15151: Set Java source version to 17
......................................................................
IMPALA-15151: Set Java source version to 17
Bump maven.compiler.source from 8 to 17 in java/pom.xml.
sun.misc.Unsafe was explicitly exempted from strong encapsulation in
Java 17 (JEP 260, JEP 403), so it remains accessible without
--add-exports.
Change-Id: Iccb7b9cc28ad8ade554298503f2d8f4dee789151
Assisted-by: Claude Sonnet 4.6 (OpenCode)
Reviewed-on: http://gerrit.cloudera.org:8080/24561
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Michael Smith <mi...@cloudera.com>
Reviewed-by: Zoltan Borok-Nagy <bo...@cloudera.com>
---
M java/pom.xml
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Michael Smith: Looks good to me, but someone else must approve
Zoltan Borok-Nagy: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/24561
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iccb7b9cc28ad8ade554298503f2d8f4dee789151
Gerrit-Change-Number: 24561
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-15151: Set Java source version to 17
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24561 )
Change subject: IMPALA-15151: Set Java source version to 17
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/23138/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24561
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iccb7b9cc28ad8ade554298503f2d8f4dee789151
Gerrit-Change-Number: 24561
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Jul 2026 14:34:03 +0000
Gerrit-HasComments: No