[GitHub] [cassandra-sidecar] tolbertam commented on a change in pull request #5: Read config from sidecar.config System Property instead of classpath

[GitBox <gi...@apache.org>]

tolbertam commented on a change in pull request #5: Read config from sidecar.config System Property instead of classpath
URL: https://github.com/apache/cassandra-sidecar/pull/5#discussion_r316801648
 
 

 ##########
 File path: build.gradle
 ##########
 @@ -39,22 +39,12 @@ run {
     confFile = "file:" + File.separator + File.separator + "$projectDir/conf/sidecar.yaml"
     jvmArgs = ["-Dsidecar.logdir=./logs",
                                  "-Dsidecar.config=" + confFile,
+                                 "-Dlogback.configurationFile=./conf/logback.xml",
                                  "-Dvertx.logger-delegate-factory-class-name=io.vertx.core.logging.SLF4JLogDelegateFactory",
-                                 "-javaagent:$projectDir/src/dist/agents/jolokia-jvm-1.6.0-agent.jar=port=7777,host=localhost"]
+                                 "-javaagent:$projectDir/agents/jolokia-jvm-1.6.0-agent.jar=port=7777,host=localhost"]
 }
 
 sourceSets {
-    // This is needed as gradle considers `src/main/resources` as the default resources folder
-    main {
-        resources {
-            srcDirs = ['conf', 'setup', 'src/main/resources']
 
 Review comment:
   I believe it's no longer needed as I relocated `conf` to `src/main/dist/conf` so it gets pulled within the distribution.  `setup` directory doesn't appear to exist, and `src/main/resources` is implicitly a resource directory so it doesn't need to be defined.
   
   The removed `test { resources` step isn't necessary now since I added a test specific test-logback.xml

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org