[GitHub] [accumulo] ctubbsii commented on pull request #2515: replace some calculation with TimeUnit

[GitBox <gi...@apache.org>]

ctubbsii commented on pull request #2515:
URL: https://github.com/apache/accumulo/pull/2515#issuecomment-1048250962


   > When you are talking about a wildcard import * are you refering to: `import static java.util.concurrent.TimeUnit.*;` Is so, why can't i use that ?
   
   It's a style choice. We like to be explicit with our imports. Here are some reasons people have made: https://stackoverflow.com/q/147454/196405
   
   The Google Style Guide for Java also forbids it (but doesn't give a reason): https://google.github.io/styleguide/javaguide.html#s3.3.1-wildcard-imports
   
   > 
   > I'm unable to run `mvn clean package -DskipTests` without issues:
   
   Please don't paste the full build output into chat. It makes it harder to follow. I edited your comment to make it easier to read. You can typically just show the last few lines that show the error, if you run into a problem.
   
   Based on the message, it looks like you don't have `bash` installed. This would be true if you were building on Windows (which we don't support), but could be true in other environments as well. Typically, you'd just install `bash`, but depending on your environment, you may need to do more than that to install all the build prerequisites. You could just let the PR checks do the build for you, since they build in a Linux environment already, but that's not as convenient as being able to build locally as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org