You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/01/19 09:02:14 UTC
[GitHub] [ozone] szetszwo opened a new pull request #2998: HDDS-6202. Avoid using jmh-generator-annprocess since it is GPL2.0.
szetszwo opened a new pull request #2998:
URL: https://github.com/apache/ozone/pull/2998
## What changes were proposed in this pull request?
jmh-generator-annprocess is GPL2.0. It is incompatible with Apache License 2.0. It is currently only used by genesis (a micro-benchmark tool).
We may have to rewrite the tool or move it out from the main Ozone code base.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6202
## How was this patch tested?
NA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #2998: HDDS-6202. Avoid using jmh-generator-annprocess since it is GPL2.0.
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #2998:
URL: https://github.com/apache/ozone/pull/2998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2998: HDDS-6202. Avoid using jmh-generator-annprocess since it is GPL2.0.
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2998:
URL: https://github.com/apache/ozone/pull/2998#issuecomment-1016665667
> Suppose genesis is a useful tool. We probably need to move the genesis code to a different maven module or even a different repo. By default, genesis won't be included with Ozone release. It will be available somewhere. Then, we may download it on demand. This is similar to the jmh-core jar in the ozone script.
I think we should move Genesis to a separate repo with different license. (I'm not sure if Apache allows such license, nor about the mechanics of a license change.)
Separate project is also recommended by JMH, too: "The recommended way to run a JMH benchmark is to use Maven to setup a standalone project that depends on the jar files of your application."
> The current genesis doc and scripts may be still useful. So, how about we fix them separately?
`ozone genesis` won't work because `Genesis.java` is being removed. I think leaving the script around would be confusing. I'm OK with fixing it separately, though. Please let me know if I should work on that part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] szetszwo commented on pull request #2998: HDDS-6202. Avoid using jmh-generator-annprocess since it is GPL2.0.
Posted by GitBox <gi...@apache.org>.
szetszwo commented on pull request #2998:
URL: https://github.com/apache/ozone/pull/2998#issuecomment-1016677881
> ... Please let me know if I should work on that part.
@adoroszlai , It would be great if you are interested in working on that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] szetszwo commented on pull request #2998: HDDS-6202. Avoid using jmh-generator-annprocess since it is GPL2.0.
Posted by GitBox <gi...@apache.org>.
szetszwo commented on pull request #2998:
URL: https://github.com/apache/ozone/pull/2998#issuecomment-1016649175
@adoroszlai , thanks a lot for reviewing this.
Suppose genesis is a useful tool. We probably need to move the genesis code to a different maven module or even a different repo. By default, genesis won't be included with Ozone release. It will be available somewhere. Then, we may download it on demand. This is similar to the jmh-core jar in the ozone script.
https://github.com/apache/ozone/blob/a59c64cccbfec49f7178073e477fce6102596aec/hadoop-ozone/dist/src/shell/ozone/ozone#L139-L142
The current genesis doc and scripts may be still useful. So, how about we fix them separately?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] szetszwo commented on pull request #2998: HDDS-6202. Avoid using jmh-generator-annprocess since it is GPL2.0.
Posted by GitBox <gi...@apache.org>.
szetszwo commented on pull request #2998:
URL: https://github.com/apache/ozone/pull/2998#issuecomment-1016676750
> ozone genesis won't work because Genesis.java is being removed.
It could possibly work:
1. Suppose genesis.jar, which contains Genesis.class and other classes, is available in maven or somewhere else.
2. Use curl to download the jar in the `ozone` script.
```
curl -o "$ARTIFACT_LIB_DIR/genesis.jar" https://repo1.maven.org/maven2/org/apache/ozone/.../genesis.jar
```
3. Then, Genesis.class is available locally. It can be executed as usual.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] szetszwo edited a comment on pull request #2998: HDDS-6202. Avoid using jmh-generator-annprocess since it is GPL2.0.
Posted by GitBox <gi...@apache.org>.
szetszwo edited a comment on pull request #2998:
URL: https://github.com/apache/ozone/pull/2998#issuecomment-1016676750
> ozone genesis won't work because Genesis.java is being removed.
It could possibly work:
1. Suppose genesis.jar, which contains Genesis.class and other classes, is available in maven or somewhere else.
2. Use curl to download the jar in the `ozone` script.
```
curl -o "$ARTIFACT_LIB_DIR/genesis.jar" https://repo1.maven.org/maven2/org/apache/ozone/.../genesis.jar
```
3. Then, Genesis.class is available locally. It can be executed as usual.
Of course, I am open to use other ways running it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2998: HDDS-6202. Avoid using jmh-generator-annprocess since it is GPL2.0.
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2998:
URL: https://github.com/apache/ozone/pull/2998#issuecomment-1016721952
> > ozone genesis won't work because Genesis.java is being removed.
>
> It could possibly work:
>
> 1. Suppose genesis.jar, which contains Genesis.class and other classes, is available in maven or somewhere else.
Got it, but my point is it will be broken until we create this separate repo and make it available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] szetszwo commented on pull request #2998: HDDS-6202. Avoid using jmh-generator-annprocess since it is GPL2.0.
Posted by GitBox <gi...@apache.org>.
szetszwo commented on pull request #2998:
URL: https://github.com/apache/ozone/pull/2998#issuecomment-1017153126
@adoroszlai , Okay, just have removed the genesis scripts and docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org