You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/25 01:23:24 UTC
[GitHub] [skywalking-swck] hanahmily opened a new pull request #26: Upgrade skywalking-cli dependency
hanahmily opened a new pull request #26:
URL: https://github.com/apache/skywalking-swck/pull/26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] fgksgf commented on a change in pull request #26: Upgrade skywalking-cli dependency
Posted by GitBox <gi...@apache.org>.
fgksgf commented on a change in pull request #26:
URL: https://github.com/apache/skywalking-swck/pull/26#discussion_r601013019
##########
File path: pkg/provider/provider.go
##########
@@ -310,3 +296,24 @@ func (p *externalMetricsProvider) selectGroupResource(namespace string) apischem
func (p *externalMetricsProvider) getMetricNameWithNamespace(metricName string) string {
return strings.Join([]string{p.namespace, metricName}, "|")
}
+
+// TODO: remove this function once cli move it from internal module to pkg
+func parseScope(entity *swctlapi.Entity) swctlapi.Scope {
Review comment:
@kezhenxu94 No problem, i will do this today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] hanahmily commented on a change in pull request #26: Upgrade skywalking-cli dependency
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #26:
URL: https://github.com/apache/skywalking-swck/pull/26#discussion_r600979938
##########
File path: pkg/provider/provider.go
##########
@@ -310,3 +296,24 @@ func (p *externalMetricsProvider) selectGroupResource(namespace string) apischem
func (p *externalMetricsProvider) getMetricNameWithNamespace(metricName string) string {
return strings.Join([]string{p.namespace, metricName}, "|")
}
+
+// TODO: remove this function once cli move it from internal module to pkg
Review comment:
on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] hanahmily merged pull request #26: Upgrade skywalking-cli dependency
Posted by GitBox <gi...@apache.org>.
hanahmily merged pull request #26:
URL: https://github.com/apache/skywalking-swck/pull/26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] wu-sheng commented on a change in pull request #26: Upgrade skywalking-cli dependency
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #26:
URL: https://github.com/apache/skywalking-swck/pull/26#discussion_r600978880
##########
File path: pkg/provider/provider.go
##########
@@ -310,3 +296,24 @@ func (p *externalMetricsProvider) selectGroupResource(namespace string) apischem
func (p *externalMetricsProvider) getMetricNameWithNamespace(metricName string) string {
return strings.Join([]string{p.namespace, metricName}, "|")
}
+
+// TODO: remove this function once cli move it from internal module to pkg
Review comment:
Do we have an issue tracking this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] kezhenxu94 commented on a change in pull request #26: Upgrade skywalking-cli dependency
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #26:
URL: https://github.com/apache/skywalking-swck/pull/26#discussion_r601012665
##########
File path: pkg/provider/provider.go
##########
@@ -310,3 +296,24 @@ func (p *externalMetricsProvider) selectGroupResource(namespace string) apischem
func (p *externalMetricsProvider) getMetricNameWithNamespace(metricName string) string {
return strings.Join([]string{p.namespace, metricName}, "|")
}
+
+// TODO: remove this function once cli move it from internal module to pkg
+func parseScope(entity *swctlapi.Entity) swctlapi.Scope {
Review comment:
> @kezhenxu94 this func is copied from cli repo. Could we move it from internal to pkg?
@fgksgf can you take over this? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] hanahmily commented on a change in pull request #26: Upgrade skywalking-cli dependency
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #26:
URL: https://github.com/apache/skywalking-swck/pull/26#discussion_r600978800
##########
File path: pkg/provider/provider.go
##########
@@ -310,3 +296,24 @@ func (p *externalMetricsProvider) selectGroupResource(namespace string) apischem
func (p *externalMetricsProvider) getMetricNameWithNamespace(metricName string) string {
return strings.Join([]string{p.namespace, metricName}, "|")
}
+
+// TODO: remove this function once cli move it from internal module to pkg
+func parseScope(entity *swctlapi.Entity) swctlapi.Scope {
Review comment:
@kezhenxu94 this func is copied from cli repo. Could we move it from internal to pkg?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org