You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by vladimir-kotikov <gi...@git.apache.org> on 2015/09/16 16:39:23 UTC
[GitHub] cordova-lib pull request: CB-9598 Introduces `cordova-common` modu...
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/309
CB-9598 Introduces `cordova-common` module
This is an implementation for [CB-9598](https://issues.apache.org/jira/browse/CB-9598) and the next step of platformApi refactoring. The idea is to move all code that potentially will be shared between different platforms and LIB into a separate module that will be used by both LIB an platforms.
This PR only copies existing code from cordova-lib into cordova-common, but doesn't switches cordova-lib to use it. Once this PR is merged we can remove this functionality from cordova-lib and switch to using cordova-common.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-9598
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/309.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #309
----
commit 1959844d1ee3053bfb87255542ff5ee7739fb541
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2015-09-16T13:39:52Z
CB-9598 Initial implementation for cordova-common module
commit 63784f6547d682ff3a30713a4d20153fb606fe11
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2015-09-16T13:39:41Z
CB-9598 Adds tests and fixtures based on existing cordova-lib ones
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9598 Introduces `cordova-common` modu...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-lib/pull/309#issuecomment-141781606
:+1: - reviewed `cordova-common` folder, run `npm install` and `npm test`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9598 Introduces `cordova-common` modu...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/309#issuecomment-141443458
@nikhilkh, regarding your concern about iOS specific dependencies (`xcode`, `plist` and `bplist-parser`) for this - the reason is that `ConfigChanges` class still uses them to do some special config processing.
We can get rid of this ios specifics only when we'll end supporing old platforms (`ios` in particular) via `PlatformApiPoly`.
BTW there is exactly the same situation with Windows platform - there is some logic that spreads appxmanifest changes to all appxmanifest files in project (see [generate_plugin_config_munge](https://github.com/MSOpenTech/cordova-lib/commit/9245da38f30e61ab98595e8916aea175f7d88f56#diff-cd932e6542e2f88b0f2c0dd0907b7481R274)), which we'll need to keep there while supporting non-platformApi-compatible platform.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9598 Introduces `cordova-common` modu...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/309#issuecomment-141443929
@sgrebnov, this is ready to merge, please take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9598 Introduces `cordova-common` modu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/309
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9598 Introduces `cordova-common` modu...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-lib/pull/309#issuecomment-141607056
sounds great, @vladimir-kotikov - I plan to complete this on weekend
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org