You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@yetus.apache.org by aw...@apache.org on 2022/08/29 15:59:29 UTC

[yetus] branch main updated: YETUS-1197 NPE in DocletEnvironmentProcessor (#285)

This is an automated email from the ASF dual-hosted git repository.

aw pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/yetus.git


The following commit(s) were added to refs/heads/main by this push:
     new 79bf9ca8 YETUS-1197 NPE in DocletEnvironmentProcessor (#285)
79bf9ca8 is described below

commit 79bf9ca89b0195cb7afe9e399fcdae9d7543c897
Author: Duo Zhang <zh...@apache.org>
AuthorDate: Mon Aug 29 23:59:23 2022 +0800

    YETUS-1197 NPE in DocletEnvironmentProcessor (#285)
---
 .../org/apache/yetus/audience/tools/DocletEnvironmentProcessor.java  | 3 +++
 .../apache/yetus/audience/tools/DocletEnvironmentProcessorTest.java  | 5 +++++
 2 files changed, 8 insertions(+)

diff --git a/audience-annotations-component/audience-annotations/src/main/java/org/apache/yetus/audience/tools/DocletEnvironmentProcessor.java b/audience-annotations-component/audience-annotations/src/main/java/org/apache/yetus/audience/tools/DocletEnvironmentProcessor.java
index 1614abc7..24305ca5 100644
--- a/audience-annotations-component/audience-annotations/src/main/java/org/apache/yetus/audience/tools/DocletEnvironmentProcessor.java
+++ b/audience-annotations-component/audience-annotations/src/main/java/org/apache/yetus/audience/tools/DocletEnvironmentProcessor.java
@@ -56,6 +56,9 @@ class DocletEnvironmentProcessor {
      * @return true iff the element should be excluded
      */
     private boolean excluded(final Element e) {
+      if (e == null) {
+        return true;
+      }
       // Exclude private and limited private types
       if (e.getAnnotation(InterfaceAudience.Private.class) != null) {
         return true;
diff --git a/audience-annotations-component/audience-annotations/src/test/java/org/apache/yetus/audience/tools/DocletEnvironmentProcessorTest.java b/audience-annotations-component/audience-annotations/src/test/java/org/apache/yetus/audience/tools/DocletEnvironmentProcessorTest.java
index cb17d04b..7ee0797f 100644
--- a/audience-annotations-component/audience-annotations/src/test/java/org/apache/yetus/audience/tools/DocletEnvironmentProcessorTest.java
+++ b/audience-annotations-component/audience-annotations/src/test/java/org/apache/yetus/audience/tools/DocletEnvironmentProcessorTest.java
@@ -141,4 +141,9 @@ public class DocletEnvironmentProcessorTest {
         assertFalse(environment.isIncluded(get(InterfaceStability.Unstable.class)));
         assertFalse(environment.isIncluded(get()));
     }
+
+    @Test
+    public void testNullElement() {
+        assertFalse(environment.isIncluded(null));
+    }
 }