You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ephraimbuddy (via GitHub)" <gi...@apache.org> on 2025/01/29 14:39:22 UTC
[PR] Add StrictHostKeyChecking option to GitDagBundle [airflow]
ephraimbuddy opened a new pull request, #46241:
URL: https://github.com/apache/airflow/pull/46241
This adds an option to enable or disable StrictHostKeyChecking in GitDagBundle. Host key is not checked by default. You have to enable host key checking in the connection extra.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add StrictHostKeyChecking option to GitDagBundle [airflow]
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on code in PR #46241:
URL: https://github.com/apache/airflow/pull/46241#discussion_r1934519679
##########
tests/dag_processing/test_dag_bundles.py:
##########
@@ -160,6 +158,22 @@ def test_correct_repo_urls(self, conn_id, expected_repo_url):
hook = GitHook(git_conn_id=conn_id)
assert hook.repo_url == expected_repo_url
+ def test_env_var(self, session):
+ hook = GitHook(git_conn_id=CONN_DEFAULT)
+ assert hook.env == {
+ "GIT_SSH_COMMAND": "ssh -i /files/pkey.pem -o IdentitiesOnly=yes -o StrictHostKeyChecking=no"
+ }
+
+ conn = session.query(Connection).filter(Connection.conn_id == CONN_DEFAULT).one()
Review Comment:
hmm, I wonder if we should do a new connection instead of mutating this "common" one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add StrictHostKeyChecking option to GitDagBundle [airflow]
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy merged PR #46241:
URL: https://github.com/apache/airflow/pull/46241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org