[GitHub] [tvm] manupa-arm commented on a change in pull request #6950: [uTVM] Initial BYOC support with c-source module

[GitBox <gi...@apache.org>]

manupa-arm commented on a change in pull request #6950:
URL: https://github.com/apache/tvm/pull/6950#discussion_r529746674



##########
File path: include/tvm/ir/module.h
##########
@@ -56,11 +56,14 @@ class IRModuleNode : public Object {
   Map<GlobalTypeVar, TypeData> type_definitions;
   /*! \brief The source map for the module. */
   parser::SourceMap source_map;
+  /*! \brief The names of external functions for func registry */
+  Array<String> ext_func_names;

Review comment:
       IIUC, by the time IRModule reaches codegen_c_host (See line 311), all the functions are PrimFunc s. Thus, it will not include the relay external functions that were taken out early in the compilation flow. However, when creating the system-lib those function names should be included in the func registry as they are also sort of "primitive" but externally compiled.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org