[GitHub] [guacamole-server] necouchman commented on pull request #322: Force fast WebP compression

[GitBox <gi...@apache.org>]

necouchman commented on pull request #322:
URL: https://github.com/apache/guacamole-server/pull/322#issuecomment-758750276


   @andrewsali: 
   
   > Given that 4 Megabits / sec bandwidth is nowadays considered fairly slow (usually it's at least an order of magnitude faster), in most cases the faster compression should result in better UX.
   
   My only comment about the bandwidth would be that, while 4 Mb/s is on the low end of individual internet connections, if you're aggregating a bunch of those together, you have the potential to hit limits. For example, if 200 users have active sessions, that has at least the potential to be 800 Mb/s, which, even for larger offices, may be at or beyond the limit of those connections. And, besides that, Guacamole may not be the only thing that those 200 users are doing - they probably have other websites opened, and, if these theoretical users are anything like the real ones I encounter day-to-day, they also have Pandora or Spotify or YouTube going, so all of the sudden 800Mb/s isn't quite as much as it used to be, and now I start to figure out how to chop that 4 Mb/s connection down some.
   
   Aside from that, it's also useful to consider the other side of the connection - the servers running Tomcat and/or guacd where those connections terminate. Not just for raw bandwidth sake, but also for cost - for example, if I'm running guacd in a public cloud provider, I'm paying for both the CPU time and the bandwidth, and it may be more cost-effective to purchase one over the other.
   
   All that is not to say that I'm opposed to the changes, just that I agree with Mike that I'm not sure hard-coding some of those parameters is a good idea - there should either be some logic and detection of connection performance that impacts them, or they should be configurable, or, perhaps, both.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org