You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/06/15 10:39:54 UTC
[GitHub] [hadoop-ozone] sadanand48 opened a new pull request #1076: HDDS-3773. Add OMDBDefinition to define structure of om.db.
sadanand48 opened a new pull request #1076:
URL: https://github.com/apache/hadoop-ozone/pull/1076
## What changes were proposed in this pull request?
In order to support the rocksdb tool which displays data for a given db file ([HDDS-3622](https://github.com/apache/hadoop-ozone/pull/945)) , the appropriate DBDefinition file must be defined. The change here is to extend the tool for om.db.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3773
## How was this patch tested?
Manual test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on pull request #1076: HDDS-3773. Add OMDBDefinition to define structure of om.db.
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1076:
URL: https://github.com/apache/hadoop-ozone/pull/1076#issuecomment-648945128
> I think we probably need to follow the same model as that in SCM. Though the patch looks good, other changes related to using DB interface rather than MetadataDataStore interface, can be done in separate jira after further analysis.
+1 Sounds like a reasonable plan for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1076: HDDS-3773. Add OMDBDefinition to define structure of om.db.
Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on pull request #1076:
URL: https://github.com/apache/hadoop-ozone/pull/1076#issuecomment-648946469
@sadanand48 / @bshashikant I am OK with handling the next set of OM changes in a different JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on pull request #1076: HDDS-3773. Add OMDBDefinition to define structure of om.db.
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1076:
URL: https://github.com/apache/hadoop-ozone/pull/1076#issuecomment-649364597
Great. I think the proposal is to do something similar to #997 in the next patch.
Now I am merging this one. Thanks the patch @sadanand48 and the review @avijayanhwx and @bshashikant
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] sadanand48 commented on pull request #1076: HDDS-3773. Add OMDBDefinition to define structure of om.db.
Posted by GitBox <gi...@apache.org>.
sadanand48 commented on pull request #1076:
URL: https://github.com/apache/hadoop-ozone/pull/1076#issuecomment-644565653
> Thank you for the patch @sadanand48. Any reason why we are not using the OMDBDefinition to actually create the OM DB, like in the SCM?
@avijayanhwx I think the plan was to use DBStore interface instead of the MetadataDataStore and in order to do that DBDefinition must be defined [(HDDS-3172)] .(https://github.com/apache/hadoop-ozone/pull/700#issuecomment-615289480).
OM currently uses the MetadataStore Interface so there is no OMDBDefinition defined.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] codecov-commenter commented on pull request #1076: HDDS-3773. Add OMDBDefinition to define structure of om.db.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1076:
URL: https://github.com/apache/hadoop-ozone/pull/1076#issuecomment-644078443
# [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1076?src=pr&el=h1) Report
> Merging [#1076](https://codecov.io/gh/apache/hadoop-ozone/pull/1076?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hadoop-ozone/commit/57a8388b902a291571bdf60ab3f91930a5cf8815&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/hadoop-ozone/pull/1076?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1076 +/- ##
============================================
- Coverage 70.46% 70.43% -0.04%
- Complexity 9242 9247 +5
============================================
Files 961 963 +2
Lines 48130 48155 +25
Branches 4676 4675 -1
============================================
+ Hits 33917 33920 +3
- Misses 11960 11985 +25
+ Partials 2253 2250 -3
```
| [Impacted Files](https://codecov.io/gh/apache/hadoop-ozone/pull/1076?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/apache/hadoop/ozone/om/codec/OMDBDefinition.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1076/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9jb2RlYy9PTURCRGVmaW5pdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/hadoop/ozone/debug/DBDefinitionFactory.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1076/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL3Rvb2xzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3Avb3pvbmUvZGVidWcvREJEZWZpbml0aW9uRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../java/org/apache/hadoop/ozone/debug/DBScanner.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1076/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL3Rvb2xzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3Avb3pvbmUvZGVidWcvREJTY2FubmVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...hdds/scm/container/CloseContainerEventHandler.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1076/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL2NvbnRhaW5lci9DbG9zZUNvbnRhaW5lckV2ZW50SGFuZGxlci5qYXZh) | `72.41% <0.00%> (-17.25%)` | `6.00% <0.00%> (ø%)` | |
| [...er/common/transport/server/GrpcXceiverService.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1076/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3RyYW5zcG9ydC9zZXJ2ZXIvR3JwY1hjZWl2ZXJTZXJ2aWNlLmphdmE=) | `70.00% <0.00%> (-10.00%)` | `3.00% <0.00%> (ø%)` | |
| [...va/org/apache/hadoop/hdds/utils/db/RDBMetrics.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1076/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvZnJhbWV3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy91dGlscy9kYi9SREJNZXRyaWNzLmphdmE=) | `85.71% <0.00%> (-7.15%)` | `13.00% <0.00%> (-1.00%)` | |
| [...e/commandhandler/CreatePipelineCommandHandler.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1076/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3N0YXRlbWFjaGluZS9jb21tYW5kaGFuZGxlci9DcmVhdGVQaXBlbGluZUNvbW1hbmRIYW5kbGVyLmphdmE=) | `87.23% <0.00%> (-4.26%)` | `8.00% <0.00%> (ø%)` | |
| [...apache/hadoop/hdds/server/events/EventWatcher.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1076/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvZnJhbWV3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy9zZXJ2ZXIvZXZlbnRzL0V2ZW50V2F0Y2hlci5qYXZh) | `77.77% <0.00%> (-4.17%)` | `14.00% <0.00%> (ø%)` | |
| [...ent/algorithms/SCMContainerPlacementRackAware.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1076/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL2NvbnRhaW5lci9wbGFjZW1lbnQvYWxnb3JpdGhtcy9TQ01Db250YWluZXJQbGFjZW1lbnRSYWNrQXdhcmUuamF2YQ==) | `76.69% <0.00%> (-3.01%)` | `31.00% <0.00%> (-2.00%)` | |
| [...java/org/apache/hadoop/hdds/utils/db/RDBTable.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1076/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvZnJhbWV3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy91dGlscy9kYi9SREJUYWJsZS5qYXZh) | `58.66% <0.00%> (-2.67%)` | `19.00% <0.00%> (-1.00%)` | |
| ... and [16 more](https://codecov.io/gh/apache/hadoop-ozone/pull/1076/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1076?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1076?src=pr&el=footer). Last update [57a8388...c27fd85](https://codecov.io/gh/apache/hadoop-ozone/pull/1076?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek merged pull request #1076: HDDS-3773. Add OMDBDefinition to define structure of om.db.
Posted by GitBox <gi...@apache.org>.
elek merged pull request #1076:
URL: https://github.com/apache/hadoop-ozone/pull/1076
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1076: HDDS-3773. Add OMDBDefinition to define structure of om.db.
Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on pull request #1076:
URL: https://github.com/apache/hadoop-ozone/pull/1076#issuecomment-644314970
Thank you for the patch @sadanand48. Any reason why we are not using the OMDBDefinition to actually create the OM DB, like in the SCM?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bshashikant commented on pull request #1076: HDDS-3773. Add OMDBDefinition to define structure of om.db.
Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #1076:
URL: https://github.com/apache/hadoop-ozone/pull/1076#issuecomment-645172805
> > Thank you for the patch @sadanand48. Any reason why we are not using the OMDBDefinition to actually create the OM DB, like in the SCM?
>
> @avijayanhwx I think the plan was to use DBStore interface instead of the MetadataDataStore and in order to do that DBDefinition must be defined [([HDDS-3172](https://issues.apache.org/jira/browse/HDDS-3172))] .([#700 (comment)](https://github.com/apache/hadoop-ozone/pull/700#issuecomment-615289480)).
> OM currently uses the MetadataStore Interface so there is no OMDBDefinition defined.
I think we probably need to follow the same model as that in SCM. Though the patch looks good, other changes related to using DB interface rather than MetadataDataStore interface, can be done in separate jira after further analysis.
@avijayanhwx , what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org