[GitHub] [fineract] mohitsinha commented on a diff in pull request #3170: [FINERACT-1906] Add disbursement charge to accrual transactions

["mohitsinha (via GitHub)" <gi...@apache.org>]

mohitsinha commented on code in PR #3170:
URL: https://github.com/apache/fineract/pull/3170#discussion_r1193122135


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -484,6 +486,15 @@ public CommandProcessingResult disburseLoan(final Long loanId, final JsonCommand
                     && loanCharge.isChargePending()) {
                 disBuLoanCharges.put(loanCharge.getId(), loanCharge.amountOutstanding());
             }
+            if (loanCharge.isDisbursementCharge()) {

Review Comment:
   Looks good.
   But can this be handled using JPA rather than Raw queries?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org