You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "equanz (via GitHub)" <gi...@apache.org> on 2024/08/02 03:36:04 UTC
[PR] [fix][test] Fixed many tests of pulsar-proxy are not running [pulsar]
equanz opened a new pull request, #23118:
URL: https://github.com/apache/pulsar/pull/23118
### Motivation
In https://github.com/apache/pulsar/pull/22179 , `io.opentelemetry:opentelemetry-sdk-testing` was introduced to pulsar-broker. In https://github.com/apache/pulsar/pull/22467 , `OpenTelemetryAssertions` was used at `org.apache.pulsar.broker.auth.MockedPulsarServiceBaseTest`.
However, test cases that extend `org.apache.pulsar.broker.auth.MockedPulsarServiceBaseTest` is not only pulsar-broker, but also pulsar-proxy and pulsar-testclient. These are not running after https://github.com/apache/pulsar/pull/22467 is introduced.
Before modification:
```
% mvn test -pl pulsar-proxy -Dtest='org.apache.pulsar.proxy.server.ProxyServiceStarterTest'
...
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.pulsar.proxy.server.ProxyServiceStarterTest
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.504 s - in org.apache.pulsar.proxy.server.ProxyServiceStarterTest
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 5.512 s
[INFO] Finished at: 2024-08-02T12:12:48+09:00
[INFO] ------------------------------------------------------------------------
[INFO] 0 goals, 0 executed
```
### Modifications
* Move io.opentelemetry:opentelemetry-sdk-testing from pulsar-broker to parent pom
After modification:
```
% mvn test -pl pulsar-proxy -Dtest='org.apache.pulsar.proxy.server.ProxyServiceStarterTest'
...
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.pulsar.proxy.server.ProxyServiceStarterTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.199 s - in org.apache.pulsar.proxy.server.ProxyServiceStarterTest
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21.533 s
[INFO] Finished at: 2024-08-02T12:10:53+09:00
[INFO] ------------------------------------------------------------------------
[INFO] 0 goals, 0 executed
```
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][test] Fixed many tests of pulsar-proxy are not running [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #23118:
URL: https://github.com/apache/pulsar/pull/23118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org