You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Fiona La (Jira)" <ji...@apache.org> on 2022/11/16 16:56:00 UTC
[jira] [Updated] (ARROW-18011) [Dev] Replace hard-coded string "master" with "main" in dev/archery/archery/crossbow/core.py after default branch migration
[ https://issues.apache.org/jira/browse/ARROW-18011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fiona La updated ARROW-18011:
-----------------------------
Description:
[https://github.com/apache/arrow/pull/14033] uses several heuristics to determine the default Git branch name for the upstream apache/arrow project. When the heuristics fail to detect the default branch name, the strategy used in [https://github.com/apache/arrow/pull/14033] currently falls back to using the hard-coded branch name "master".
After [https://github.com/apache/arrow/pull/14033] is merged and after the upstream apache/arrow GitHub repository migrates to using "main" as the default branch name, the hard-coded string "master" should be replaced with "main" inside of the implementation of the computed property "default_branch_name" of the "Repo" class in dev/archery/archery/crossbow/core.py.
A similar instance of hard-coded "master" is used in `[dev/merge_arrow_pr.py|https://github.com/apache/arrow/pull/14533/files#diff-4aea0167b68c23bb8725640aec90bfc1d4caed14e9c21e1b64d65a54f9b47e63]` and it needs to be updated as well.
was:
[https://github.com/apache/arrow/pull/14033] uses several heuristics to determine the default Git branch name for the upstream apache/arrow project. When the heuristics fail to detect the default branch name, the strategy used in [https://github.com/apache/arrow/pull/14033] currently falls back to using the hard-coded branch name "master".
After [https://github.com/apache/arrow/pull/14033] is merged and after the upstream apache/arrow GitHub repository migrates to using "main" as the default branch name, the hard-coded string "master" should be replaced with "main" inside of the implementation of the computed property "default_branch_name" of the "Repo" class in dev/archery/archery/crossbow/core.py.
> [Dev] Replace hard-coded string "master" with "main" in dev/archery/archery/crossbow/core.py after default branch migration
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: ARROW-18011
> URL: https://issues.apache.org/jira/browse/ARROW-18011
> Project: Apache Arrow
> Issue Type: Sub-task
> Components: Developer Tools
> Reporter: Kevin Gurney
> Priority: Major
>
> [https://github.com/apache/arrow/pull/14033] uses several heuristics to determine the default Git branch name for the upstream apache/arrow project. When the heuristics fail to detect the default branch name, the strategy used in [https://github.com/apache/arrow/pull/14033] currently falls back to using the hard-coded branch name "master".
> After [https://github.com/apache/arrow/pull/14033] is merged and after the upstream apache/arrow GitHub repository migrates to using "main" as the default branch name, the hard-coded string "master" should be replaced with "main" inside of the implementation of the computed property "default_branch_name" of the "Repo" class in dev/archery/archery/crossbow/core.py.
> A similar instance of hard-coded "master" is used in `[dev/merge_arrow_pr.py|https://github.com/apache/arrow/pull/14533/files#diff-4aea0167b68c23bb8725640aec90bfc1d4caed14e9c21e1b64d65a54f9b47e63]` and it needs to be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)