You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/13 15:26:45 UTC
[GitHub] [superset] rusackas commented on a change in pull request #16168: fix(Dashboard): Omnibar dropdown visibility and keyboard commands
rusackas commented on a change in pull request #16168:
URL: https://github.com/apache/superset/pull/16168#discussion_r688599001
##########
File path: superset-frontend/src/components/OmniContainer/OmniContainer.test.tsx
##########
@@ -84,40 +84,6 @@ test('Open Omnibar with ctrl + k with featureflag enabled', () => {
).not.toBeVisible();
});
-test('Open Omnibar with ctrl + s with featureflag enabled', () => {
Review comment:
It seems like this test could be written with `K` and `esc` keystrokes, to keep it rather than delete it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org