You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/12 18:54:49 UTC
[GitHub] [beam] andoni-guzman opened a new pull request, #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
andoni-guzman opened a new pull request, #17354:
URL: https://github.com/apache/beam/pull/17354
This PR created a test only for python sickbays post commit test)
Move from post commit it to post commit sickbay test.
If in a future more tests needs to be moved to sickbay test. Only add this market to the code should be enough
@pytest.mark.it_postcommit_sickbay
Test moved to sickbay
- test_copy_batch_rewrite_token
- test_copy_rewrite_token
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem merged pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
pabloem merged PR #17354:
URL: https://github.com/apache/beam/pull/17354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] andoni-guzman commented on pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
andoni-guzman commented on PR #17354:
URL: https://github.com/apache/beam/pull/17354#issuecomment-1104482804
Run Python 3.8 PostCommit Sickbay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #17354:
URL: https://github.com/apache/beam/pull/17354#issuecomment-1104455197
I have run the seed job successfully against this PR (https://ci-beam.apache.org/job/beam_SeedJob/9547/ and then I wasn't sure if the timer trigger overwrote so I started again at https://ci-beam.apache.org/job/beam_SeedJob/9549/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #17354:
URL: https://github.com/apache/beam/pull/17354#issuecomment-1098331400
Run Seed Job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] andoni-guzman commented on pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
andoni-guzman commented on PR #17354:
URL: https://github.com/apache/beam/pull/17354#issuecomment-1101657988
Hi @pabloem I update the PR with the changes related with the comments, and answer the other questions in the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] andoni-guzman commented on pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
andoni-guzman commented on PR #17354:
URL: https://github.com/apache/beam/pull/17354#issuecomment-1110039194
Run Python 3.8 PostCommit Sickbay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #17354:
URL: https://github.com/apache/beam/pull/17354#issuecomment-1110131905
successful seed job: https://ci-beam.apache.org/job/beam_SeedJob/9589/console
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #17354:
URL: https://github.com/apache/beam/pull/17354#issuecomment-1098462104
I was able to manually run this: https://ci-beam.apache.org/job/beam_SeedJob/9519/console
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] andoni-guzman commented on pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
andoni-guzman commented on PR #17354:
URL: https://github.com/apache/beam/pull/17354#issuecomment-1097107015
R: @kileys
Hi Kiley, can you review this PR please.
Also run a seed job to test the new Run Python ${pythonVersion} PostCommit Sickbay and Run Python ${pythonVersion} PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #17354:
URL: https://github.com/apache/beam/pull/17354#issuecomment-1110195142
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on a diff in pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
kennknowles commented on code in PR #17354:
URL: https://github.com/apache/beam/pull/17354#discussion_r855495073
##########
sdks/python/test-suites/dataflow/common.gradle:
##########
@@ -124,6 +124,30 @@ task postCommitIT {
}
}
+task postCommitSickbay {
+ dependsOn 'installGcpTest'
+ dependsOn ':sdks:python:sdist'
+ dependsOn ':runners:google-cloud-dataflow-java:worker:shadowJar'
+
+ def dataflowWorkerJar = project(":runners:google-cloud-dataflow-java:worker").shadowJar.archivePath
Review Comment:
You would be `--data_service_options=use_runner_v2` I believe. It may need to be `--experiments=use_runner_v2` if that does not work (but it is not an experiment any more).
Pablo - is `apache-beam-testing` excluded from auto opt in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] andoni-guzman commented on pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
andoni-guzman commented on PR #17354:
URL: https://github.com/apache/beam/pull/17354#issuecomment-1104482046
Run Python 3.8 PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] andoni-guzman commented on pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
andoni-guzman commented on PR #17354:
URL: https://github.com/apache/beam/pull/17354#issuecomment-1105817051
Run Python 3.8 PostCommit Sickbay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] andoni-guzman commented on pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
andoni-guzman commented on PR #17354:
URL: https://github.com/apache/beam/pull/17354#issuecomment-1110034486
Run Python 3.8 PostCommit Sickbay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #17354:
URL: https://github.com/apache/beam/pull/17354#issuecomment-1110138360
Run of sickbayed tests: https://ci-beam.apache.org/job/beam_PostCommit_Sickbay_Python39_PR/1/
They fail as is normal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on a diff in pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
pabloem commented on code in PR #17354:
URL: https://github.com/apache/beam/pull/17354#discussion_r849877962
##########
.test-infra/jenkins/job_PostCommit_Python_Sickbay.groovy:
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import CommonJobProperties as commonJobProperties
+import PostcommitJobBuilder
+
+import static PythonTestProperties.ALL_SUPPORTED_VERSIONS
Review Comment:
let's make sure that these tests run on a schedule (maybe every 12 hours or so)
##########
sdks/python/test-suites/dataflow/common.gradle:
##########
@@ -124,6 +124,30 @@ task postCommitIT {
}
}
+task postCommitSickbay {
+ dependsOn 'installGcpTest'
+ dependsOn ':sdks:python:sdist'
+ dependsOn ':runners:google-cloud-dataflow-java:worker:shadowJar'
+
+ def dataflowWorkerJar = project(":runners:google-cloud-dataflow-java:worker").shadowJar.archivePath
Review Comment:
I don't think we need this. I'd like to run these on Runner V2 only. Do you know how to set this up as a Runner V2 test?
##########
sdks/python/apache_beam/io/gcp/gcsio_integration_test.py:
##########
@@ -121,8 +121,9 @@ def test_copy_kms(self):
raise unittest.SkipTest('--kms_key_name not specified')
self._test_copy("test_copy_kms", self.kms_key_name)
- @pytest.mark.it_postcommit
- @unittest.skip('BEAM-12352: enable once maxBytesRewrittenPerCall works again')
+ @pytest.mark.it_postcommit_sickbay
+ #@pytest.mark.it_postcommit Enable when this test is not more sickbay
+ #@unittest.skip('BEAM-12352: enable once maxBytesRewrittenPerCall works again')
Review Comment:
ditto
##########
sdks/python/apache_beam/io/gcp/gcsio_integration_test.py:
##########
@@ -175,8 +176,9 @@ def test_copy_batch_kms(self):
raise unittest.SkipTest('--kms_key_name not specified')
self._test_copy_batch("test_copy_batch_kms", self.kms_key_name)
- @pytest.mark.it_postcommit
- @unittest.skip('BEAM-12352: enable once maxBytesRewrittenPerCall works again')
+ @pytest.mark.it_postcommit_sickbay
+ #@pytest.mark.it_postcommit Enable when this test is not sickbay
+ #@unittest.skip('BEAM-12352: enable once maxBytesRewrittenPerCall works again')
Review Comment:
remove the unittest.skip line please? but leave BEAM-12352 in a comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #17354:
URL: https://github.com/apache/beam/pull/17354#issuecomment-1098462575
Run Python 3.8 PostCommit Sickbay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] andoni-guzman commented on a diff in pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
andoni-guzman commented on code in PR #17354:
URL: https://github.com/apache/beam/pull/17354#discussion_r849930246
##########
.test-infra/jenkins/job_PostCommit_Python_Sickbay.groovy:
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import CommonJobProperties as commonJobProperties
+import PostcommitJobBuilder
+
+import static PythonTestProperties.ALL_SUPPORTED_VERSIONS
Review Comment:
Yes. This test run each 6 hours , because use the postcommit job builder
`commonJobProperties.setAutoJob delegate, '0 */6 * * *', 'builds@beam.apache.org', true, true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #17354:
URL: https://github.com/apache/beam/pull/17354#issuecomment-1110131709
Run Python 3.9 PostCommit Sickbay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] andoni-guzman commented on pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
andoni-guzman commented on PR #17354:
URL: https://github.com/apache/beam/pull/17354#issuecomment-1105816821
Run Python 3.8 PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #17354:
URL: https://github.com/apache/beam/pull/17354#issuecomment-1110138483
Run Python 3.8 PostCommit Sickbay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17354:
URL: https://github.com/apache/beam/pull/17354#issuecomment-1097100110
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17354:
URL: https://github.com/apache/beam/pull/17354#issuecomment-1097100109
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] andoni-guzman commented on pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
andoni-guzman commented on PR #17354:
URL: https://github.com/apache/beam/pull/17354#issuecomment-1098461341
Hi @pabloem . I think that the trigger of the seed job failed. :c I don't see a seed job run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] andoni-guzman commented on a diff in pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
andoni-guzman commented on code in PR #17354:
URL: https://github.com/apache/beam/pull/17354#discussion_r849930246
##########
.test-infra/jenkins/job_PostCommit_Python_Sickbay.groovy:
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import CommonJobProperties as commonJobProperties
+import PostcommitJobBuilder
+
+import static PythonTestProperties.ALL_SUPPORTED_VERSIONS
Review Comment:
Yes. This test run every 6 hours , because use the postcommit job builder
`commonJobProperties.setAutoJob delegate, '0 */6 * * *', 'builds@beam.apache.org', true, true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] andoni-guzman commented on a diff in pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
andoni-guzman commented on code in PR #17354:
URL: https://github.com/apache/beam/pull/17354#discussion_r849928446
##########
sdks/python/test-suites/dataflow/common.gradle:
##########
@@ -124,6 +124,30 @@ task postCommitIT {
}
}
+task postCommitSickbay {
+ dependsOn 'installGcpTest'
+ dependsOn ':sdks:python:sdist'
+ dependsOn ':runners:google-cloud-dataflow-java:worker:shadowJar'
+
+ def dataflowWorkerJar = project(":runners:google-cloud-dataflow-java:worker").shadowJar.archivePath
Review Comment:
I don't know how to set up as a Runner V2.
I did in this way to be sure that the sickbay test have the same configuration as normal post commit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #17354:
URL: https://github.com/apache/beam/pull/17354#issuecomment-1097117867
# [Codecov](https://codecov.io/gh/apache/beam/pull/17354?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17354](https://codecov.io/gh/apache/beam/pull/17354?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7aa38c0) into [master](https://codecov.io/gh/apache/beam/commit/12330d8cffc06a067c4f26c8733663e0d7fcbdc1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (12330d8) will **increase** coverage by `9.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #17354 +/- ##
==========================================
+ Coverage 74.61% 83.63% +9.01%
==========================================
Files 653 460 -193
Lines 81802 63888 -17914
==========================================
- Hits 61037 53431 -7606
+ Misses 19784 10457 -9327
+ Partials 981 0 -981
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `83.63% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/17354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/io/jdbc.py](https://codecov.io/gh/apache/beam/pull/17354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vamRiYy5weQ==) | `78.26% <0.00%> (-6.74%)` | :arrow_down: |
| [sdks/python/apache\_beam/typehints/opcodes.py](https://codecov.io/gh/apache/beam/pull/17354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL29wY29kZXMucHk=) | `84.89% <0.00%> (-5.82%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/gcp/bigtableio.py](https://codecov.io/gh/apache/beam/pull/17354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3RhYmxlaW8ucHk=) | `74.69% <0.00%> (-4.79%)` | :arrow_down: |
| [...n/apache\_beam/runners/interactive/cache\_manager.py](https://codecov.io/gh/apache/beam/pull/17354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9jYWNoZV9tYW5hZ2VyLnB5) | `87.58% <0.00%> (-3.40%)` | :arrow_down: |
| [...pache\_beam/dataframe/pandas\_top\_level\_functions.py](https://codecov.io/gh/apache/beam/pull/17354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL3BhbmRhc190b3BfbGV2ZWxfZnVuY3Rpb25zLnB5) | `90.52% <0.00%> (-3.16%)` | :arrow_down: |
| [...nternal/clients/cloudbuild/cloudbuild\_v1\_client.py](https://codecov.io/gh/apache/beam/pull/17354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9jbGllbnRzL2Nsb3VkYnVpbGQvY2xvdWRidWlsZF92MV9jbGllbnQucHk=) | `52.21% <0.00%> (-2.97%)` | :arrow_down: |
| [...s/python/apache\_beam/runners/portability/stager.py](https://codecov.io/gh/apache/beam/pull/17354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zdGFnZXIucHk=) | `85.54% <0.00%> (-2.75%)` | :arrow_down: |
| [...ers/portability/fn\_api\_runner/watermark\_manager.py](https://codecov.io/gh/apache/beam/pull/17354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dhdGVybWFya19tYW5hZ2VyLnB5) | `93.33% <0.00%> (-2.67%)` | :arrow_down: |
| [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/17354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `94.26% <0.00%> (-2.29%)` | :arrow_down: |
| [sdks/python/apache\_beam/coders/typecoders.py](https://codecov.io/gh/apache/beam/pull/17354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3R5cGVjb2RlcnMucHk=) | `92.40% <0.00%> (-2.12%)` | :arrow_down: |
| ... and [351 more](https://codecov.io/gh/apache/beam/pull/17354/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/17354?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/17354?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [12330d8...7aa38c0](https://codecov.io/gh/apache/beam/pull/17354?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17354:
URL: https://github.com/apache/beam/pull/17354#issuecomment-1097100114
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kileys commented on pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
kileys commented on PR #17354:
URL: https://github.com/apache/beam/pull/17354#issuecomment-1097201943
R: @pabloem
cc: @kennknowles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #17354: BEAM-14170 - Create a test that runs sickbayed tests ( Python Sickbay tests)
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #17354:
URL: https://github.com/apache/beam/pull/17354#issuecomment-1110138551
Run Python 3.7 PostCommit Sickbay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org