You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2014/08/20 17:52:27 UTC

[jira] [Commented] (LUCENE-5894) refactor bulk merge logic

    [ https://issues.apache.org/jira/browse/LUCENE-5894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104061#comment-14104061 ] 

Michael McCandless commented on LUCENE-5894:
--------------------------------------------

+1, I think this patch is nice; it's great to have merging fully under
control of the codec.  There are lots of nice improvements here:

  * SegmentMerger is much simpler

  * Merging responsibility moves to XXXConsumer, and bulk-merge optos
    (and new MatchingReaders class) are now entirely codec private
    (CompressingStoredFields/TVFormat)

  * Moved old writers (Lucene40StoredFields/TVsWriter) to
    test-framework so compressing (current default) is the only writer
    now.

  * We now need a NormsConsumer/Producer (can't reuse DVConsumer) since the
    source for norms must be "known" in the default merge impl.

  * Factored out SegmentDocValuesProducer to hold all per-field DVPs,
    updates.

  * Also separated out the classes in IW that buffer up norms in RAM
    until flush from the DV classes, letting you remove
    trackDocsWithField boolean...

I think this is a good cleanup!


> refactor bulk merge logic
> -------------------------
>
>                 Key: LUCENE-5894
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5894
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Robert Muir
>         Attachments: LUCENE-5894.patch
>
>
> Today its only usable really by stored fields/term vectors, has hardcoded logic in SegmentMerger specific to certain impls, etc.
> It would be better if this was generalized to terms/postings/norms/docvalues as well.
> Bulk merge is boring, the real idea is to allow codecs to do more: e.g. with this patch they could do streaming checksum validation, or prevent the loading of "latent" norms, or other things we cannot do today.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org