You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2015/12/12 00:52:25 UTC
Review Request 41291: Modified the scheduler tests to use the new
executor HTTP based library.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41291/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-3550
https://issues.apache.org/jira/browse/MESOS-3550
Repository: mesos
Description
-------
This change modifies the existing scheduler tests to use the new executor HTTP library instead of the old driver based interface.
Diffs
-----
src/tests/scheduler_tests.cpp 67432109c7df6be0aa76e94a03bd5b2e9c96d14e
Diff: https://reviews.apache.org/r/41291/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 41291: Modified the scheduler tests to use the new
executor HTTP based library.
Posted by Anand Mazumdar <ma...@gmail.com>.
> On Feb. 3, 2016, 11:41 p.m., Vinod Kone wrote:
> > src/tests/scheduler_tests.cpp, line 201
> > <https://reviews.apache.org/r/41291/diff/5/?file=1194021#file1194021line201>
> >
> > s/execCallbacks/executorCallbacks/
Renamed this to `executor` now as per our discussion.
> On Feb. 3, 2016, 11:41 p.m., Vinod Kone wrote:
> > src/tests/scheduler_tests.cpp, lines 303-305
> > <https://reviews.apache.org/r/41291/diff/5/?file=1194021#file1194021line303>
> >
> > It would be gret if we can send a TASK_RUNNING update right from here, like we did with the driver based executor to minimize the boiler plate code needed for every test.
> >
> > This likely means that the ExecutorCallbacks class needs access to a pointer of TestMesos class.
Added the ability to pass the pointer to `TestMesos`. Cleaned up things a lot. Thanks for the suggestion.
> On Feb. 3, 2016, 11:41 p.m., Vinod Kone wrote:
> > src/tests/scheduler_tests.cpp, line 308
> > <https://reviews.apache.org/r/41291/diff/5/?file=1194021#file1194021line308>
> >
> > s/exec/executor/
We no longer get access to `TestMesos` now. Hence, the issue is no longer valid. Dropping.
- Anand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41291/#review117703
-----------------------------------------------------------
On Feb. 4, 2016, 11:12 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41291/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2016, 11:12 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-4457
> https://issues.apache.org/jira/browse/MESOS-4457
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change modifies the existing scheduler tests to use the new executor HTTP library instead of the old driver based interface.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp 4e2db2ac40c59b9b9a97cd214b3cd1e727a4f0ad
>
> Diff: https://reviews.apache.org/r/41291/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 41291: Modified the scheduler tests to use the new
executor HTTP based library.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41291/#review117703
-----------------------------------------------------------
src/tests/scheduler_tests.cpp (line 201)
<https://reviews.apache.org/r/41291/#comment178977>
s/execCallbacks/executorCallbacks/
src/tests/scheduler_tests.cpp (lines 266 - 267)
<https://reviews.apache.org/r/41291/#comment178978>
this expectation should be set much later. sometime after #287?
src/tests/scheduler_tests.cpp (lines 297 - 299)
<https://reviews.apache.org/r/41291/#comment178989>
It would be gret if we can send a TASK_RUNNING update right from here, like we did with the driver based executor to minimize the boiler plate code needed for every test.
This likely means that the ExecutorCallbacks class needs access to a pointer of TestMesos class.
src/tests/scheduler_tests.cpp (line 302)
<https://reviews.apache.org/r/41291/#comment178979>
s/exec/executor/
src/tests/scheduler_tests.cpp (line 360)
<https://reviews.apache.org/r/41291/#comment178982>
do the above changes for all the other tests below.
- Vinod Kone
On Jan. 22, 2016, 8:35 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41291/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 8:35 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-4457
> https://issues.apache.org/jira/browse/MESOS-4457
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change modifies the existing scheduler tests to use the new executor HTTP library instead of the old driver based interface.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp 67432109c7df6be0aa76e94a03bd5b2e9c96d14e
>
> Diff: https://reviews.apache.org/r/41291/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 41291: Modified the scheduler tests to use the new
executor HTTP based library.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41291/#review115972
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41275, 41277, 41280, 41281, 41282, 41283, 41288, 41290, 41291]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 22, 2016, 8:35 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41291/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 8:35 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-4457
> https://issues.apache.org/jira/browse/MESOS-4457
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change modifies the existing scheduler tests to use the new executor HTTP library instead of the old driver based interface.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp 67432109c7df6be0aa76e94a03bd5b2e9c96d14e
>
> Diff: https://reviews.apache.org/r/41291/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 41291: Modified the scheduler tests to use the new
executor HTTP based library.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41291/#review118343
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 9, 2016, 12:14 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41291/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 12:14 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-4457
> https://issues.apache.org/jira/browse/MESOS-4457
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change modifies the existing scheduler tests to use the new executor HTTP library instead of the old driver based interface.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp 4e2db2ac40c59b9b9a97cd214b3cd1e727a4f0ad
>
> Diff: https://reviews.apache.org/r/41291/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 41291: Modified the scheduler tests to use the new
executor HTTP based library.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41291/#review118354
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41288, 43225, 41290, 41291]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 9, 2016, 1:49 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41291/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 1:49 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-4457
> https://issues.apache.org/jira/browse/MESOS-4457
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change modifies the existing scheduler tests to use the new executor HTTP library instead of the old driver based interface.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp 4e2db2ac40c59b9b9a97cd214b3cd1e727a4f0ad
>
> Diff: https://reviews.apache.org/r/41291/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 41291: Modified the scheduler tests to use the new
executor HTTP based library.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41291/
-----------------------------------------------------------
(Updated Feb. 9, 2016, 1:49 a.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Review comments on r41288
Bugs: MESOS-4457
https://issues.apache.org/jira/browse/MESOS-4457
Repository: mesos
Description
-------
This change modifies the existing scheduler tests to use the new executor HTTP library instead of the old driver based interface.
Diffs (updated)
-----
src/tests/scheduler_tests.cpp 4e2db2ac40c59b9b9a97cd214b3cd1e727a4f0ad
Diff: https://reviews.apache.org/r/41291/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 41291: Modified the scheduler tests to use the new
executor HTTP based library.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41291/
-----------------------------------------------------------
(Updated Feb. 9, 2016, 12:14 a.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Review comments from Vinod
Bugs: MESOS-4457
https://issues.apache.org/jira/browse/MESOS-4457
Repository: mesos
Description
-------
This change modifies the existing scheduler tests to use the new executor HTTP library instead of the old driver based interface.
Diffs (updated)
-----
src/tests/scheduler_tests.cpp 4e2db2ac40c59b9b9a97cd214b3cd1e727a4f0ad
Diff: https://reviews.apache.org/r/41291/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 41291: Modified the scheduler tests to use the new
executor HTTP based library.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41291/#review117952
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41288, 43225, 41290, 41291]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 4, 2016, 11:12 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41291/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2016, 11:12 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-4457
> https://issues.apache.org/jira/browse/MESOS-4457
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change modifies the existing scheduler tests to use the new executor HTTP library instead of the old driver based interface.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp 4e2db2ac40c59b9b9a97cd214b3cd1e727a4f0ad
>
> Diff: https://reviews.apache.org/r/41291/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 41291: Modified the scheduler tests to use the new
executor HTTP based library.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41291/#review118309
-----------------------------------------------------------
src/tests/scheduler_tests.cpp (lines 252 - 258)
<https://reviews.apache.org/r/41291/#comment179532>
reorder?
src/tests/scheduler_tests.cpp (lines 376 - 382)
<https://reviews.apache.org/r/41291/#comment179533>
reorder.
src/tests/scheduler_tests.cpp (lines 645 - 651)
<https://reviews.apache.org/r/41291/#comment179534>
reorder?
src/tests/scheduler_tests.cpp (lines 771 - 777)
<https://reviews.apache.org/r/41291/#comment179535>
reorder.
src/tests/scheduler_tests.cpp (lines 1177 - 1183)
<https://reviews.apache.org/r/41291/#comment179536>
reorder
src/tests/scheduler_tests.cpp (line 1212)
<https://reviews.apache.org/r/41291/#comment179537>
s/data/message/
- Vinod Kone
On Feb. 4, 2016, 11:12 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41291/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2016, 11:12 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-4457
> https://issues.apache.org/jira/browse/MESOS-4457
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change modifies the existing scheduler tests to use the new executor HTTP library instead of the old driver based interface.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp 4e2db2ac40c59b9b9a97cd214b3cd1e727a4f0ad
>
> Diff: https://reviews.apache.org/r/41291/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 41291: Modified the scheduler tests to use the new
executor HTTP based library.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41291/
-----------------------------------------------------------
(Updated Feb. 4, 2016, 11:12 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Review comments
Bugs: MESOS-4457
https://issues.apache.org/jira/browse/MESOS-4457
Repository: mesos
Description
-------
This change modifies the existing scheduler tests to use the new executor HTTP library instead of the old driver based interface.
Diffs (updated)
-----
src/tests/scheduler_tests.cpp 4e2db2ac40c59b9b9a97cd214b3cd1e727a4f0ad
Diff: https://reviews.apache.org/r/41291/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 41291: Modified the scheduler tests to use the new
executor HTTP based library.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41291/
-----------------------------------------------------------
(Updated Jan. 22, 2016, 8:35 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Updated JIRA
Bugs: MESOS-4457
https://issues.apache.org/jira/browse/MESOS-4457
Repository: mesos
Description
-------
This change modifies the existing scheduler tests to use the new executor HTTP library instead of the old driver based interface.
Diffs
-----
src/tests/scheduler_tests.cpp 67432109c7df6be0aa76e94a03bd5b2e9c96d14e
Diff: https://reviews.apache.org/r/41291/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 41291: Modified the scheduler tests to use the new
executor HTTP based library.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41291/
-----------------------------------------------------------
(Updated Jan. 12, 2016, 9:51 a.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Rebased
Bugs: MESOS-3550
https://issues.apache.org/jira/browse/MESOS-3550
Repository: mesos
Description
-------
This change modifies the existing scheduler tests to use the new executor HTTP library instead of the old driver based interface.
Diffs (updated)
-----
src/tests/scheduler_tests.cpp 67432109c7df6be0aa76e94a03bd5b2e9c96d14e
Diff: https://reviews.apache.org/r/41291/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 41291: Modified the scheduler tests to use the new
executor HTTP based library.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41291/
-----------------------------------------------------------
(Updated Jan. 12, 2016, 9:22 a.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Rebased
Bugs: MESOS-3550
https://issues.apache.org/jira/browse/MESOS-3550
Repository: mesos
Description
-------
This change modifies the existing scheduler tests to use the new executor HTTP library instead of the old driver based interface.
Diffs (updated)
-----
src/tests/scheduler_tests.cpp 67432109c7df6be0aa76e94a03bd5b2e9c96d14e
Diff: https://reviews.apache.org/r/41291/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 41291: Modified the scheduler tests to use the new
executor HTTP based library.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41291/#review110103
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41275, 41277, 41280, 41281, 41282, 41283, 41285, 41288, 41290, 41291]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 12, 2015, 11:50 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41291/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 11:50 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-3550
> https://issues.apache.org/jira/browse/MESOS-3550
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change modifies the existing scheduler tests to use the new executor HTTP library instead of the old driver based interface.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp 67432109c7df6be0aa76e94a03bd5b2e9c96d14e
>
> Diff: https://reviews.apache.org/r/41291/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 41291: Modified the scheduler tests to use the new
executor HTTP based library.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41291/
-----------------------------------------------------------
(Updated Dec. 12, 2015, 11:50 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Fixed a race condition that showed up on ASF CI(reviewbot) where the executor `connected` callback can be invoked before `Containerizer::_launch` is completed. Surprisingly, they pass on my box with 300+ iterations.
Bugs: MESOS-3550
https://issues.apache.org/jira/browse/MESOS-3550
Repository: mesos
Description
-------
This change modifies the existing scheduler tests to use the new executor HTTP library instead of the old driver based interface.
Diffs (updated)
-----
src/tests/scheduler_tests.cpp 67432109c7df6be0aa76e94a03bd5b2e9c96d14e
Diff: https://reviews.apache.org/r/41291/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 41291: Modified the scheduler tests to use the new
executor HTTP based library.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41291/
-----------------------------------------------------------
(Updated Dec. 12, 2015, 2:15 a.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Make reviewbot run again.
Bugs: MESOS-3550
https://issues.apache.org/jira/browse/MESOS-3550
Repository: mesos
Description
-------
This change modifies the existing scheduler tests to use the new executor HTTP library instead of the old driver based interface.
Diffs (updated)
-----
src/tests/scheduler_tests.cpp 67432109c7df6be0aa76e94a03bd5b2e9c96d14e
Diff: https://reviews.apache.org/r/41291/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar