You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Likitha Shetty <li...@citrix.com> on 2013/02/01 06:55:38 UTC

Review Request: [EC2 Query API] DescribeSnapshots fails, when an invalid 'snapshotId' parameter is provided

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9227/
-----------------------------------------------------------

Review request for cloudstack and Prachi Damle.


Description
-------

EC2DescribeSnapshotS fails with an NPE when an invalid snapshot id is provided as input


This addresses bug CLOUDSTACK-1112.


Diffs
-----

  awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java 17752af 

Diff: https://reviews.apache.org/r/9227/diff/


Testing
-------

For boto client, Run ec2_get_all_snapshots with 'a' as parameter input for filter snapshot-id. Result should be empty response.


Thanks,

Likitha Shetty


Re: Review Request: [EC2 Query API] DescribeSnapshots fails, when an invalid 'snapshotId' parameter is provided

Posted by Prachi Damle <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9227/#review16438
-----------------------------------------------------------

Ship it!


Bug fix looks ok, Commit hash:	5d09b9fd3a025491c59d76af1af7412fa8d3cb28


- Prachi Damle


On Feb. 1, 2013, 5:55 a.m., Likitha Shetty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9227/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2013, 5:55 a.m.)
> 
> 
> Review request for cloudstack and Prachi Damle.
> 
> 
> Description
> -------
> 
> EC2DescribeSnapshotS fails with an NPE when an invalid snapshot id is provided as input
> 
> 
> This addresses bug CLOUDSTACK-1112.
> 
> 
> Diffs
> -----
> 
>   awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java 17752af 
> 
> Diff: https://reviews.apache.org/r/9227/diff/
> 
> 
> Testing
> -------
> 
> For boto client, Run ec2_get_all_snapshots with 'a' as parameter input for filter snapshot-id. Result should be empty response.
> 
> 
> Thanks,
> 
> Likitha Shetty
> 
>