You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2022/11/02 13:34:05 UTC
[httpcomponents-core] branch master updated (1d68d86d0 -> e1544687f)
This is an automated email from the ASF dual-hosted git repository.
olegk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/httpcomponents-core.git
omit 1d68d86d0 Updated release notes for HttpCore 5.2 release
new 8fabd3dc1 HTTPCORE-727 (follow-up): async HTTP/1.1 protocol handler fails to count bytes transferred while flushing session buffer when writing out a message head or suspending session output.
new d04dcb048 Bug fix: async HTTP/1.1 server protocol handler incorrectly increments request count upon receipt of a response message head.
new e1544687f Updated release notes for HttpCore 5.2 release
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (1d68d86d0)
\
N -- N -- N refs/heads/master (e1544687f)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
RELEASE_NOTES.txt | 14 --------------
.../core5/http/impl/nio/AbstractHttp1StreamDuplexer.java | 10 ++++++++--
.../hc/core5/http/impl/nio/ServerHttp1StreamDuplexer.java | 2 +-
3 files changed, 9 insertions(+), 17 deletions(-)
[httpcomponents-core] 02/03: Bug fix: async HTTP/1.1 server protocol handler incorrectly increments request count upon receipt of a response message head.
Posted by ol...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
olegk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/httpcomponents-core.git
commit d04dcb048b55477d5e030fc0c334bea24fcab2a9
Author: Oleg Kalnichevski <ol...@apache.org>
AuthorDate: Wed Nov 2 12:55:49 2022 +0100
Bug fix: async HTTP/1.1 server protocol handler incorrectly increments request count upon receipt of a response message head.
---
.../org/apache/hc/core5/http/impl/nio/ServerHttp1StreamDuplexer.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/impl/nio/ServerHttp1StreamDuplexer.java b/httpcore5/src/main/java/org/apache/hc/core5/http/impl/nio/ServerHttp1StreamDuplexer.java
index d256feffa..fafd72fc6 100644
--- a/httpcore5/src/main/java/org/apache/hc/core5/http/impl/nio/ServerHttp1StreamDuplexer.java
+++ b/httpcore5/src/main/java/org/apache/hc/core5/http/impl/nio/ServerHttp1StreamDuplexer.java
@@ -244,7 +244,7 @@ public class ServerHttp1StreamDuplexer extends AbstractHttp1StreamDuplexer<HttpR
@Override
void updateOutputMetrics(final HttpResponse response, final BasicHttpConnectionMetrics connMetrics) {
if (response.getCode() >= HttpStatus.SC_OK) {
- connMetrics.incrementRequestCount();
+ connMetrics.incrementResponseCount();
}
}
[httpcomponents-core] 03/03: Updated release notes for HttpCore 5.2 release
Posted by ol...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
olegk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/httpcomponents-core.git
commit e1544687fa6aa67fb0296e04c098a71c2ba73e20
Author: Oleg Kalnichevski <ol...@apache.org>
AuthorDate: Sat Oct 29 12:53:31 2022 +0200
Updated release notes for HttpCore 5.2 release
---
RELEASE_NOTES.txt | 64 +++++++++++++++++++++++++++++++++++--------------------
1 file changed, 41 insertions(+), 23 deletions(-)
diff --git a/RELEASE_NOTES.txt b/RELEASE_NOTES.txt
index a0d664a6c..cdae9de71 100644
--- a/RELEASE_NOTES.txt
+++ b/RELEASE_NOTES.txt
@@ -1,23 +1,8 @@
-Release 5.2 BETA3
+Release 5.2
------------------
-* Deprecate org.apache.hc.core5.util.LangUtils.equals(Object[], Object[]) in favor or java.util.Arrays.equals(Object[], Object[]).
-* Deprecate org.apache.hc.core5.util.LangUtils.equals(Object, Object) in favor or java.util.Objects.equals(Object, Object).
-* Bump JUnit from 5.8.2 to 5.9.1 #363.
-* Bump mockito-core from 4.4.0 to 4.8.0 #366.
-* Bump JApiCmp from 0.15.4 to 0.15.7.
-* Bump reactive-streams from 1.0.3 to 1.0.4 #364.
-* Bump rxjava from 3.1.3 to 3.1.5 #362.
-* Bump commons-cli from 1.4 to 1.5.0 #365.
-
-
-Release 5.2 BETA2
-------------------
-
-This BETA release corrects a major regression in the TLS handshake handling
-code introduced in the previous BETA release.
-
-This release also includes all fixes from the 5.1 (stable) branch.
+This is the first GA release in the 5.2 release series. This release finalizes the 5.2 APIs
+and also corrects a number of defects discovered since the previous release.
Please note that 5.2 upgrades the minimal JRE level to version 8 (8u251 is required).
@@ -29,13 +14,50 @@ Notable changes and features included in the 5.2 series:
* Improved HTTP protocol negotiation.
-* Improved customization of HTTP listeners (async).
+* Improved customization of connection listeners (async).
* Improved parsing and formatting of URI components.
* Use of Java 8 date / time APIs
+Change Log
+-------------------
+
+* Bug fix: HTTP/1.1 protocol handler must continue message processing as long as there is data
+ in the session input buffer.
+ Contributed by Oleg Kalnichevski <olegk at apache.org>
+
+* HTTPCORE-726: Improved capacity management in SharedInputBuffer.
+ Contributed by John Leacox <johnlcox at gmail.com>
+
+* Bug fix: Fixed incorrect calculation of the capacity increment in StringAsyncEntityConsumer.
+ Contributed by Oleg Kalnichevski <olegk at apache.org>
+
+* Add and use TLS accessor methods to use lambdas from httpclient5 later.
+ Contributed by Gary Gregory <garydgregory at gmail.com>
+
+* Deprecate org.apache.hc.core5.util.LangUtils.equals(Object, Object) in
+ favor or java.util.Objects.equals(Object, Object).
+ Deprecate org.apache.hc.core5.util.LangUtils.equals(Object[], Object[])
+ in favor or java.util.Arrays.equals(Object[], Object[]).
+ Contributed by Gary Gregory <garydgregory at gmail.com>
+
+* URI Builder performance optimization (#355)
+ Contributed by jkmcl <jkmcl at users.noreply.github.com>
+
+
+Release 5.2 BETA2
+------------------
+
+This BETA release corrects a major regression in the TLS handshake handling
+code introduced in the previous BETA release.
+
+This release also includes all fixes from the 5.1 (stable) branch.
+
+Please note that 5.2 upgrades the minimal JRE level to version 8 (8u251 is required).
+
+
Change Log
-------------------
@@ -337,10 +359,6 @@ Release 5.1 BETA2
This is the second BETA release in the 5.1 release series that includes a number of
new features as well as bug fixes from the stable 5.0.x branch.
-Notable changes and features included in the 5.1 series:
-
-* Application protocol upgrade support for non-blocking HTTP/1.1 connections.
-
Change Log
-------------------
[httpcomponents-core] 01/03: HTTPCORE-727 (follow-up): async HTTP/1.1 protocol handler fails to count bytes transferred while flushing session buffer when writing out a message head or suspending session output.
Posted by ol...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
olegk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/httpcomponents-core.git
commit 8fabd3dc130a6a3ebb037faf736acd0cb46e0b0e
Author: Oleg Kalnichevski <ol...@apache.org>
AuthorDate: Wed Nov 2 12:53:07 2022 +0100
HTTPCORE-727 (follow-up): async HTTP/1.1 protocol handler fails to count bytes transferred while flushing session buffer when writing out a message head or suspending session output.
---
.../hc/core5/http/impl/nio/AbstractHttp1StreamDuplexer.java | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/impl/nio/AbstractHttp1StreamDuplexer.java b/httpcore5/src/main/java/org/apache/hc/core5/http/impl/nio/AbstractHttp1StreamDuplexer.java
index aec812e7a..b60adf2dc 100644
--- a/httpcore5/src/main/java/org/apache/hc/core5/http/impl/nio/AbstractHttp1StreamDuplexer.java
+++ b/httpcore5/src/main/java/org/apache/hc/core5/http/impl/nio/AbstractHttp1StreamDuplexer.java
@@ -446,7 +446,10 @@ abstract class AbstractHttp1StreamDuplexer<IncomingMessage extends HttpMessage,
}
outgoingMessageWriter.reset();
if (flushMode == FlushMode.IMMEDIATE) {
- outbuf.flush(ioSession);
+ final int bytesWritten = outbuf.flush(ioSession);
+ if (bytesWritten > 0) {
+ outTransportMetrics.incrementBytesTransferred(bytesWritten);
+ }
}
ioSession.setEvent(EventMask.WRITE);
} finally {
@@ -479,7 +482,10 @@ abstract class AbstractHttp1StreamDuplexer<IncomingMessage extends HttpMessage,
ioSession.getLock().lock();
try {
if (outbuf.hasData()) {
- outbuf.flush(ioSession);
+ final int bytesWritten = outbuf.flush(ioSession);
+ if (bytesWritten > 0) {
+ outTransportMetrics.incrementBytesTransferred(bytesWritten);
+ }
} else {
ioSession.clearEvent(SelectionKey.OP_WRITE);
}