You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "jsbxyyx (via GitHub)" <gi...@apache.org> on 2024/11/22 02:34:31 UTC
[PR] When all server channel not available, fail fast [incubator-seata]
jsbxyyx opened a new pull request, #7023:
URL: https://github.com/apache/incubator-seata/pull/7023
<!-- Please make sure you have read and understood the contributing guidelines -->
- [ ] I have registered the PR [changes](../changes).
### Ⅰ. Describe what this PR did
optimize: all server channel not available, fail fast
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: fail fast, when all server channel not available [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes merged PR #7023:
URL: https://github.com/apache/incubator-seata/pull/7023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: fail fast, when all server channel not available [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on PR #7023:
URL: https://github.com/apache/incubator-seata/pull/7023#issuecomment-2496928853
Error: /home/runner/work/incubator-seata/incubator-seata/server/src/main/java/org/apache/seata/server/controller/VGroupMappingController.java:21:8: Unused import - org.apache.seata.common.util.StringUtils. [UnusedImports]
Error: /home/runner/work/incubator-seata/incubator-seata/server/src/main/java/org/apache/seata/server/controller/VGroupMappingController.java:32:8: Unused import - javax.annotation.PostConstruct. [UnusedImports]
Error: /home/runner/work/incubator-seata/incubator-seata/server/src/main/java/org/apache/seata/server/controller/VGroupMappingController.java:34:15: Unused import - org.apache.seata.common.ConfigurationKeys.FILE_CONFIG_SPLIT_CHAR. [UnusedImports]
Error: /home/runner/work/incubator-seata/incubator-seata/server/src/main/java/org/apache/seata/server/controller/VGroupMappingController.java:35:15: Unused import - org.apache.seata.common.ConfigurationKeys.FILE_ROOT_REGISTRY. [UnusedImports]
Error: /home/runner/work/incubator-seata/incubator-seata/server/src/main/java/org/apache/seata/server/controller/VGroupMappingController.java:36:15: Unused import - org.apache.seata.common.ConfigurationKeys.FILE_ROOT_TYPE. [UnusedImports]
Error: /home/runner/work/incubator-seata/incubator-seata/server/src/main/java/org/apache/seata/server/controller/VGroupMappingController.java:37:15: Unused import - org.apache.seata.common.ConfigurationKeys.NAMING_SERVER. [UnusedImports]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: fail fast, when all server channel not available [incubator-seata]
Posted by "jsbxyyx (via GitHub)" <gi...@apache.org>.
jsbxyyx closed pull request #7023: optimize: fail fast, when all server channel not available
URL: https://github.com/apache/incubator-seata/pull/7023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: fail fast, when all server channel not available [incubator-seata]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7023:
URL: https://github.com/apache/incubator-seata/pull/7023#issuecomment-2496970234
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/7023?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
> Project coverage is 52.62%. Comparing base [(`a3fd17c`)](https://app.codecov.io/gh/apache/incubator-seata/commit/a3fd17ca89fcb9287f7279b34a7d4a433006a6d3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`1b67a03`)](https://app.codecov.io/gh/apache/incubator-seata/commit/1b67a03651c9e30872126ca2d058216ca87bed38?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 1 commits behind head on 2.x.
| [Files with missing lines](https://app.codecov.io/gh/apache/incubator-seata/pull/7023?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...eata/core/rpc/netty/NettyClientChannelManager.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7023?src=pr&el=tree&filepath=core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fcore%2Frpc%2Fnetty%2FNettyClientChannelManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvY29yZS9ycGMvbmV0dHkvTmV0dHlDbGllbnRDaGFubmVsTWFuYWdlci5qYXZh) | 0.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/incubator-seata/pull/7023?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/incubator-seata/pull/7023?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## 2.x #7023 +/- ##
============================================
- Coverage 52.63% 52.62% -0.01%
+ Complexity 6595 6592 -3
============================================
Files 1126 1126
Lines 40007 40004 -3
Branches 4696 4694 -2
============================================
- Hits 21058 21053 -5
+ Misses 16944 16943 -1
- Partials 2005 2008 +3
```
| [Files with missing lines](https://app.codecov.io/gh/apache/incubator-seata/pull/7023?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ata/server/controller/VGroupMappingController.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7023?src=pr&el=tree&filepath=server%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fserver%2Fcontroller%2FVGroupMappingController.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9zZXJ2ZXIvY29udHJvbGxlci9WR3JvdXBNYXBwaW5nQ29udHJvbGxlci5qYXZh) | `9.52% <ø> (-6.48%)` | :arrow_down: |
| [...eata/core/rpc/netty/NettyClientChannelManager.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7023?src=pr&el=tree&filepath=core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fcore%2Frpc%2Fnetty%2FNettyClientChannelManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvY29yZS9ycGMvbmV0dHkvTmV0dHlDbGllbnRDaGFubmVsTWFuYWdlci5qYXZh) | `59.87% <0.00%> (-0.39%)` | :arrow_down: |
... and [4 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/7023/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
----
🚨 Try these New Features:
- [Flaky Tests Detection](https://docs.codecov.com/docs/test-result-ingestion-beta) - Detect and resolve failed and flaky tests
- [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis) - Avoid shipping oversized bundles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org