You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/08 09:31:17 UTC
[GitHub] [airflow] turbaszek opened a new pull request #11346: Replace nuke with useful information on error page
turbaszek opened a new pull request #11346:
URL: https://github.com/apache/airflow/pull/11346
This PR replaces nuke asciiart with text about reporting a bug.
As we are no longer using asciiarts this PR removes it.
# Before changes:
<img width="1274" alt="Screenshot 2020-10-08 at 11 30 30" src="https://user-images.githubusercontent.com/9528307/95440857-b6e2fa80-0959-11eb-97c8-c2b68b5b7e34.png">
# After changes:
<img width="1274" alt="Screenshot 2020-10-08 at 11 19 53" src="https://user-images.githubusercontent.com/9528307/95440527-58b61780-0959-11eb-96fe-d81458a0e84d.png">
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #11346: Replace nuke with useful information on error page
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #11346:
URL: https://github.com/apache/airflow/pull/11346#issuecomment-705522997
> I could certainly brainstorm and suggest some sort of visual flourish to enhance/provide some levity to the page.
That would be awesome and we can do this in follow ups PRs. Probably refreshing error pages would be nice!
> (Off camping without a computer for the rest of the week, so won't be able to address until next week)
Enjoy it! ⛺
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] olchas commented on a change in pull request #11346: Replace nuke with useful information on error page
Posted by GitBox <gi...@apache.org>.
olchas commented on a change in pull request #11346:
URL: https://github.com/apache/airflow/pull/11346#discussion_r502305369
##########
File path: airflow/www/templates/airflow/traceback.html
##########
@@ -23,10 +23,15 @@
</head>
<body>
<div class="container">
- <h1> Ooops. </h1>
+ <h1> Ooops! </h1>
<div>
<pre>
-{{ nukular }}Node: {{ hostname }}
+Something bad had happen.
+Please consider letting us know by creating an <b><a href="https://github.com/apache/airflow/issues/new/choose">bug report using Github</a></b>.
Review comment:
```suggestion
Please consider letting us know by creating a <b><a href="https://github.com/apache/airflow/issues/new/choose">bug report using Github</a></b>.
```
##########
File path: airflow/www/templates/airflow/traceback.html
##########
@@ -23,10 +23,15 @@
</head>
<body>
<div class="container">
- <h1> Ooops. </h1>
+ <h1> Ooops! </h1>
<div>
<pre>
-{{ nukular }}Node: {{ hostname }}
+Something bad had happen.
Review comment:
```suggestion
Something bad has happened.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #11346: Replace nuke with useful information on error page
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #11346:
URL: https://github.com/apache/airflow/pull/11346#issuecomment-705476929
> Why do you want to remove nuclear image?
Using nuclear mushroom in professional software is not feasible in my opinion. This is not a lovely little kitten, it's a result of weapon of mass destruction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] olchas commented on a change in pull request #11346: Replace nuke with useful information on error page
Posted by GitBox <gi...@apache.org>.
olchas commented on a change in pull request #11346:
URL: https://github.com/apache/airflow/pull/11346#discussion_r502305369
##########
File path: airflow/www/templates/airflow/traceback.html
##########
@@ -23,10 +23,15 @@
</head>
<body>
<div class="container">
- <h1> Ooops. </h1>
+ <h1> Ooops! </h1>
<div>
<pre>
-{{ nukular }}Node: {{ hostname }}
+Something bad had happen.
+Please consider letting us know by creating an <b><a href="https://github.com/apache/airflow/issues/new/choose">bug report using Github</a></b>.
Review comment:
```suggestion
Please consider letting us know by creating a <b><a href="https://github.com/apache/airflow/issues/new/choose">bug report using Github</a></b>.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #11346: Replace nuke with useful information on error page
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #11346:
URL: https://github.com/apache/airflow/pull/11346#issuecomment-705459822
Why is this picture bothering you? In my opinion, this is a nice easter egg. I am for adding a description, but an additional one, not instead of nuclear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #11346: Replace nuke with useful information on error page
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #11346:
URL: https://github.com/apache/airflow/pull/11346#issuecomment-705459822
Why do you want to remove nuclear image? In my opinion, this is a nice easter egg. I am for adding a description, but an additional one, not instead of nuclear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #11346: Replace nuke with useful information on error page
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #11346:
URL: https://github.com/apache/airflow/pull/11346#issuecomment-705476929
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #11346: Replace nuke with useful information on error page
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #11346:
URL: https://github.com/apache/airflow/pull/11346#issuecomment-705477508
CCing @ryanahamilton as frontend expert
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #11346: Replace nuke with useful information on error page
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #11346:
URL: https://github.com/apache/airflow/pull/11346#issuecomment-705459822
Why is this picture bothering you? In my opinion, this is a nice easter egg. I am for adding a description, but an additional one, not instead of nuclear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek merged pull request #11346: Replace nuke with useful information on error page
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #11346:
URL: https://github.com/apache/airflow/pull/11346
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #11346: Replace nuke with useful information on error page
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #11346:
URL: https://github.com/apache/airflow/pull/11346#issuecomment-705459822
Why do you want to remove nuclear image? In my opinion, this is a nice easter egg. I am for adding a description, but an additional one, not instead of nuclear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on pull request #11346: Replace nuke with useful information on error page
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on pull request #11346:
URL: https://github.com/apache/airflow/pull/11346#issuecomment-705500204
@turbaszek I like these changes. I could certainly brainstorm and suggest some sort of visual flourish to enhance/provide some levity to the page.
(Off camping without a computer for the rest of the week, so won't be able to address until next week)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on pull request #11346: Replace nuke with useful information on error page
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on pull request #11346:
URL: https://github.com/apache/airflow/pull/11346#issuecomment-705500204
@turbaszek I like these changes. I could certainly brainstorm and suggest some sort of visual flourish to enhance/provide some levity to the page.
(Off camping without a computer for the rest of the week, so won't be able to address until next week)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] olchas commented on a change in pull request #11346: Replace nuke with useful information on error page
Posted by GitBox <gi...@apache.org>.
olchas commented on a change in pull request #11346:
URL: https://github.com/apache/airflow/pull/11346#discussion_r502305512
##########
File path: airflow/www/templates/airflow/traceback.html
##########
@@ -23,10 +23,15 @@
</head>
<body>
<div class="container">
- <h1> Ooops. </h1>
+ <h1> Ooops! </h1>
<div>
<pre>
-{{ nukular }}Node: {{ hostname }}
+Something bad had happen.
Review comment:
```suggestion
Something bad has happened.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org