You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by andrijapanic <gi...@git.apache.org> on 2015/03/06 12:12:37 UTC

[GitHub] cloudstack-docs-admin pull request: Update templates.rst

GitHub user andrijapanic opened a pull request:

    https://github.com/apache/cloudstack-docs-admin/pull/25

    Update templates.rst

    Added extension .in to the file cloud-set-guest-password - in the part when doing chkconfig and chmod (since we donwload script with the ".in" extension - cloud-set-guest-password.in

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andrijapanic/cloudstack-docs-admin patch-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack-docs-admin/pull/25.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #25
    
----
commit 5f599804a1fab3416293715f9d1b27eb461b7eb8
Author: andrijapanic <an...@users.noreply.github.com>
Date:   2015-03-06T11:12:16Z

    Update templates.rst
    
    Added extension .in to the file cloud-set-guest-password - in the part when doing chkconfig and chmod (since we donwload script with the ".in" extension - cloud-set-guest-password.in

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin pull request: Update templates.rst

Posted by pdion891 <gi...@git.apache.org>.

Github user pdion891 commented on the pull request:

    https://github.com/apache/cloudstack-docs-admin/pull/25#issuecomment-77752534
  
    Hi Andrija, do you know a reason why we should keep .in on the filename, so far, the cloud-set-guest-password and cloud-set-guest-sshkey script are always rename to remove the .in which I suspect as been added to avoid download problem since they are bash script.
    
    Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin pull request: Update templates.rst

Posted by pdion891 <gi...@git.apache.org>.

Github user pdion891 commented on the pull request:

    https://github.com/apache/cloudstack-docs-admin/pull/25#issuecomment-77761263
  
    Hi Andrija, I cannot apply to patch, I've made a lot of change yesturday which confict :-S. Do you think you could rebase your fork and resubmit a new patch?
    
    Thanks,


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin pull request: Update templates.rst

Posted by andrijapanic <gi...@git.apache.org>.

Github user andrijapanic closed the pull request at:

    https://github.com/apache/cloudstack-docs-admin/pull/25


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin pull request: Update templates.rst

Posted by andrijapanic <gi...@git.apache.org>.

Github user andrijapanic commented on the pull request:

    https://github.com/apache/cloudstack-docs-admin/pull/25#issuecomment-77759122
  
    Hi Pierrre - actually I dont see any value adding .in extension - but the rename part was missing - so the docs is "incomplete" - we can as well just add 1 line with "mv cloud-set-guest-password.in cloud-set-guest-password" - it just wasnt complete, so I changed it that way...
    I personaly did rename it, removed .in extension...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---