You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/13 04:47:15 UTC
[GitHub] [superset] ktmud opened a new pull request #12483: fix(dashboard): use datasource id from slice metadata
ktmud opened a new pull request #12483:
URL: https://github.com/apache/superset/pull/12483
### SUMMARY
Fixes #12480
1. Always use datasource uid (or `parameter`, or `key`, whatever you call it) from the `slice.datasource_id` and `slice.datasource_type`, instead of the `datasource` field stored in `form_data` (`slice.params`), as they can be out of sync.
2. Update the import scripts to account for this and update `datasource` in `slice.params` with real dataset id associated with uuid.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
#### Before
Adding charts from the new samples data in dashboard edit mode throws an error:
#### After
It does not throw an error
### TEST PLAN
CI
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #12163 #12162 #12480
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #12483: fix(dashboard): use datasource id from slice metadata
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #12483:
URL: https://github.com/apache/superset/pull/12483
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12483: fix(dashboard): use datasource id from slice metadata
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12483:
URL: https://github.com/apache/superset/pull/12483#issuecomment-759205833
# [Codecov](https://codecov.io/gh/apache/superset/pull/12483?src=pr&el=h1) Report
> Merging [#12483](https://codecov.io/gh/apache/superset/pull/12483?src=pr&el=desc) (b6d9a19) into [master](https://codecov.io/gh/apache/superset/commit/8f83afcf494c0f5065b828294368d23717587c80?el=desc) (8f83afc) will **increase** coverage by `0.42%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12483?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12483 +/- ##
==========================================
+ Coverage 62.77% 63.19% +0.42%
==========================================
Files 1015 486 -529
Lines 49537 29909 -19628
Branches 5079 0 -5079
==========================================
- Hits 31096 18902 -12194
+ Misses 18232 11007 -7225
+ Partials 209 0 -209
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.19% <100.00%> (-0.90%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12483?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| ... and [550 more](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12483?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12483?src=pr&el=footer). Last update [8f83afc...b6d9a19](https://codecov.io/gh/apache/superset/pull/12483?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc removed a comment on pull request #12483: fix(dashboard): use datasource id from slice metadata
Posted by GitBox <gi...@apache.org>.
junlincc removed a comment on pull request #12483:
URL: https://github.com/apache/superset/pull/12483#issuecomment-759267065
LGTM!
Manually tested by adding a few charts created with new sample data, the reported issue seems gone. Thank you for the quick fix! @ktmud
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12483: fix(dashboard): use datasource id from slice metadata
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12483:
URL: https://github.com/apache/superset/pull/12483#discussion_r556812494
##########
File path: superset/charts/commands/importers/v1/__init__.py
##########
@@ -69,26 +70,29 @@ def _import(
database_ids[str(database.uuid)] = database.id
# import datasets with the correct parent ref
- dataset_info: Dict[str, Dict[str, Any]] = {}
+ datasets: Dict[str, SqlaTable] = {}
Review comment:
Current importer doesn't support Druid datasource anyway, `BaseDatasource` does not have other attributes referenced at [L92](https://github.com/apache/superset/blob/f8270b0b80c51d32a23661d104416b6b5df395d5/superset/charts/commands/importers/v1/__init__.py#L92) and [L94](https://github.com/apache/superset/blob/f8270b0b80c51d32a23661d104416b6b5df395d5/superset/charts/commands/importers/v1/__init__.py#L94).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #12483: fix(dashboard): use datasource id from slice metadata
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12483:
URL: https://github.com/apache/superset/pull/12483#issuecomment-759267065
LGTM!
Manually tested by adding a few charts created with new sample data, the reported issue seems gone. Thank you for the quick fix! @ktmud
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12483: fix(dashboard): use datasource id from slice metadata
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12483:
URL: https://github.com/apache/superset/pull/12483#issuecomment-759205833
# [Codecov](https://codecov.io/gh/apache/superset/pull/12483?src=pr&el=h1) Report
> Merging [#12483](https://codecov.io/gh/apache/superset/pull/12483?src=pr&el=desc) (0848644) into [master](https://codecov.io/gh/apache/superset/commit/8f83afcf494c0f5065b828294368d23717587c80?el=desc) (8f83afc) will **decrease** coverage by `2.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/12483?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12483 +/- ##
==========================================
- Coverage 62.77% 60.76% -2.01%
==========================================
Files 1015 529 -486
Lines 49537 19614 -29923
Branches 5079 5080 +1
==========================================
- Hits 31096 11919 -19177
+ Misses 18232 7487 -10745
+ Partials 209 208 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `60.76% <0.00%> (+<0.01%)` | :arrow_up: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12483?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.90% <0.00%> (+0.40%)` | :arrow_up: |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `55.21% <0.00%> (-0.28%)` | :arrow_down: |
| [...end/src/visualizations/FilterBox/transformProps.js](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | | |
| [...ons/versions/811494c0cc23\_remove\_path\_from\_logs.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84MTE0OTRjMGNjMjNfcmVtb3ZlX3BhdGhfZnJvbV9sb2dzLnB5) | | |
| [superset/utils/hashing.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvaGFzaGluZy5weQ==) | | |
| [...ersions/45731db65d9c\_security\_converge\_datasets.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy80NTczMWRiNjVkOWNfc2VjdXJpdHlfY29udmVyZ2VfZGF0YXNldHMucHk=) | | |
| [superset/databases/dao.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | | |
| [...ns/versions/4451805bbaa1\_remove\_double\_percents.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy80NDUxODA1YmJhYTFfcmVtb3ZlX2RvdWJsZV9wZXJjZW50cy5weQ==) | | |
| [...ersions/732f1c06bcbf\_add\_fetch\_values\_predicate.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83MzJmMWMwNmJjYmZfYWRkX2ZldGNoX3ZhbHVlc19wcmVkaWNhdGUucHk=) | | |
| ... and [477 more](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12483?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12483?src=pr&el=footer). Last update [8f83afc...b6d9a19](https://codecov.io/gh/apache/superset/pull/12483?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #12483: fix(dashboard): use datasource id from slice metadata
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #12483:
URL: https://github.com/apache/superset/pull/12483#discussion_r556664909
##########
File path: superset/charts/commands/importers/v1/__init__.py
##########
@@ -69,26 +70,29 @@ def _import(
database_ids[str(database.uuid)] = database.id
# import datasets with the correct parent ref
- dataset_info: Dict[str, Dict[str, Any]] = {}
+ datasets: Dict[str, SqlaTable] = {}
Review comment:
While this is nowadays practically always `SqlaTable`, strictly speaking I think this should be `BaseDatasource`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12483: fix(dashboard): use datasource id from slice metadata
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12483:
URL: https://github.com/apache/superset/pull/12483#issuecomment-759205833
# [Codecov](https://codecov.io/gh/apache/superset/pull/12483?src=pr&el=h1) Report
> Merging [#12483](https://codecov.io/gh/apache/superset/pull/12483?src=pr&el=desc) (eca3460) into [master](https://codecov.io/gh/apache/superset/commit/8f83afcf494c0f5065b828294368d23717587c80?el=desc) (8f83afc) will **increase** coverage by `0.42%`.
> The diff coverage is `87.50%`.
[](https://codecov.io/gh/apache/superset/pull/12483?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12483 +/- ##
==========================================
+ Coverage 62.77% 63.19% +0.42%
==========================================
Files 1015 486 -529
Lines 49537 29910 -19627
Branches 5079 0 -5079
==========================================
- Hits 31096 18902 -12194
+ Misses 18232 11008 -7224
+ Partials 209 0 -209
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.19% <87.50%> (-0.90%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12483?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.86% <0.00%> (-0.51%)` | :arrow_down: |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| ... and [551 more](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12483?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12483?src=pr&el=footer). Last update [8f83afc...b6d9a19](https://codecov.io/gh/apache/superset/pull/12483?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #12483: fix(dashboard): use datasource id from slice metadata
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #12483:
URL: https://github.com/apache/superset/pull/12483#issuecomment-759577836
Merging for inclusion in 1.0.0rc2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12483: fix(dashboard): use datasource id from slice metadata
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12483:
URL: https://github.com/apache/superset/pull/12483#issuecomment-759205833
# [Codecov](https://codecov.io/gh/apache/superset/pull/12483?src=pr&el=h1) Report
> Merging [#12483](https://codecov.io/gh/apache/superset/pull/12483?src=pr&el=desc) (b6d9a19) into [master](https://codecov.io/gh/apache/superset/commit/8f83afcf494c0f5065b828294368d23717587c80?el=desc) (8f83afc) will **increase** coverage by `0.75%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12483?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12483 +/- ##
==========================================
+ Coverage 62.77% 63.52% +0.75%
==========================================
Files 1015 486 -529
Lines 49537 29909 -19628
Branches 5079 0 -5079
==========================================
- Hits 31096 19001 -12095
+ Misses 18232 10908 -7324
+ Partials 209 0 -209
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.52% <100.00%> (-0.56%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12483?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `82.45% <0.00%> (-3.51%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.68% <0.00%> (-0.47%)` | :arrow_down: |
| ... and [536 more](https://codecov.io/gh/apache/superset/pull/12483/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12483?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12483?src=pr&el=footer). Last update [8f83afc...b6d9a19](https://codecov.io/gh/apache/superset/pull/12483?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] adam-stasiak commented on pull request #12483: fix(dashboard): use datasource id from slice metadata
Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #12483:
URL: https://github.com/apache/superset/pull/12483#issuecomment-759453099
manually tested - ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org