[jira] [Commented] (YARN-3765) Fix findbugs the warning in YARN-2928 branch, TimelineMetric

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14571709#comment-14571709 ] 

Hadoop QA commented on YARN-3765:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch |  16m 22s | Pre-patch YARN-2928 has 1 extant Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac |   7m 45s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 47s | There were no new javadoc warning messages. |
| {color:green}+1{color} | release audit |   0m 22s | The applied patch does not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   1m  1s | There were no new checkstyle issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace. |
| {color:green}+1{color} | install |   1m 38s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 42s | The patch built with eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 34s | The patch does not introduce any new Findbugs (version 3.0.0) warnings, and fixes 1 pre-existing warnings. |
| {color:green}+1{color} | yarn tests |   0m 25s | Tests passed in hadoop-yarn-api. |
| | |  39m 40s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12737370/YARN-3765-YARN-2928.001.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | YARN-2928 / 2e12480 |
| Pre-patch Findbugs warnings | https://builds.apache.org/job/PreCommit-YARN-Build/8185/artifact/patchprocess/YARN-2928FindbugsWarningshadoop-yarn-api.html |
| hadoop-yarn-api test log | https://builds.apache.org/job/PreCommit-YARN-Build/8185/artifact/patchprocess/testrun_hadoop-yarn-api.txt |
| Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/8185/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8185/console |


This message was automatically generated.

> Fix findbugs the warning in YARN-2928 branch, TimelineMetric
> ------------------------------------------------------------
>
>                 Key: YARN-3765
>                 URL: https://issues.apache.org/jira/browse/YARN-3765
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Li Lu
>            Assignee: Li Lu
>         Attachments: YARN-3765-YARN-2928.001.patch
>
>
> There is one warning about reversing the return value of comparisons in YARN-2928 branch. This is a valid warning. Quoting the findbugs warning message:
> RV_NEGATING_RESULT_OF_COMPARETO: Negating the result of compareTo()/compare()
> This code negatives the return value of a compareTo or compare method. This is a questionable or bad programming practice, since if the return value is Integer.MIN_VALUE, negating the return value won't negate the sign of the result. You can achieve the same intended result by reversing the order of the operands rather than by negating the results.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)