[GitHub] [spark] zhengruifeng commented on pull request #38841: [SPARK-41325] [CONNECT] Fix missing avg() for GroupBy on DF

[GitBox <gi...@apache.org>]

zhengruifeng commented on PR #38841:
URL: https://github.com/apache/spark/pull/38841#issuecomment-1331575966

   this pr itself lgtm, but there are behavior changes in `groupby.{min, max, sum, avg, mean}`:
   
   1, pyspark and scala api only accept string `*str` / `string*`
   2, pyspark and scala api will check the schema, if the datatype is unexpected, it fails;
   3, if the no input column, it will check the schema and select all the numeric columns.
   
   
   shall we add a dedicate proto for `groupby.{min, max, sum, avg, mean}`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org