You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by sandhyasun <gi...@git.apache.org> on 2015/09/18 08:31:31 UTC
[GitHub] incubator-trafodion pull request: [TRAFODION-28] Copyright header ...
GitHub user sandhyasun opened a pull request:
https://github.com/apache/incubator-trafodion/pull/85
[TRAFODION-28] Copyright header changes part 2
This set corrects the copyrights in some leftover core directories, dcs and core/rest and test files.
See Jira for more details.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sandhyasun/incubator-trafodion sandhya_copyright2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/85.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #85
----
commit 610305210ecf99114f45f936eb362b0c036b0356
Author: Sandhya Sundaresan <sa...@esgyn.com>
Date: 2015-09-11T06:07:23Z
Copyright headers set #1
commit 8f822e76472472c0856f7f279e1725492c0c2e9a
Author: Sandhya Sundaresan <sa...@esgyn.com>
Date: 2015-09-11T21:31:14Z
copuright header changes set 2
commit d3f73dbcb50ae74229f67da883be48733f99e5a2
Author: Sandhya Sundaresan <sa...@esgyn.com>
Date: 2015-09-18T06:15:46Z
copyright changes in dcs and rest and removing HP references in asciidocs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-28] Copyright header ...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/85#discussion_r39879294
--- Diff: core/sql/regress/newregr/mvs/BIG/EXPECTEDMV215C ---
@@ -20,21 +20,6 @@
-- @@@ END COPYRIGHT @@@
-- @@@ START COPYRIGHT @@@
--- End diff --
Did the copyright go missing in the new version?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-28] Copyright header ...
Posted by sandhyasun <gi...@git.apache.org>.
Github user sandhyasun commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/85#discussion_r39885426
--- Diff: core/sql/regress/newregr/mvs/BIG/EXPECTEDMV215C ---
@@ -20,21 +20,6 @@
-- @@@ END COPYRIGHT @@@
-- @@@ START COPYRIGHT @@@
--- End diff --
It is still there. Will remove the erroneous @@@ START COPYRIGHT sign. The newregr directory has some missing copyrights too. Will fix on next pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-28] Copyright header ...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/85#discussion_r39878948
--- Diff: core/dbsecurity/scripts/sqcertgen ---
@@ -108,7 +108,7 @@ stateOrProvinceName_default = California
localityName = Locality Name (eg, city)
localityName_default = Cupertino
0.organizationName = Organization Name (eg, company)
-0.organizationName_default = Hewlett-Packard Company
+0.organizationName_default = Esgyn Corporation
--- End diff --
Similar comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-28] Copyright header ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/85
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-28] Copyright header ...
Posted by sandhyasun <gi...@git.apache.org>.
Github user sandhyasun commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/85#discussion_r39888378
--- Diff: core/rest/src/main/java/org/trafodion/rest/TransactionsResource.java ---
@@ -62,8 +69,26 @@
}
/**
- * Constructor
- * @throws IOException
+* @@@ START COPYRIGHT @@@
--- End diff --
Yes - looks like the script replaced those "comment" lines ! Corrected this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-28] Copyright header ...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/85#discussion_r39878923
--- Diff: core/conn/unixodbc/odbc/odbcclient/unixcli/TCPIPV4/TCPIPV4.RC ---
@@ -45,11 +45,11 @@ BEGIN
BLOCK "000004b0"
BEGIN
VALUE "Comments", "T7968G10_01NOV2004_ABC_IPV4_1220\0"
- VALUE "CompanyName", "Hewlett-Packard Company\0"
+ VALUE "CompanyName", "Esgyn Corporation\0"
VALUE "FileDescription", "NonStop� ODBC/MX TCPIPV4 DLL\0"
--- End diff --
I'm wondering what the significance of "CompanyName" is. Perhaps we should put Apache Software Foundation here? Also, I'm wondering if we should take out "NonStop ODBC/MX" and replace it with something like "Apache Trafodion ODBC"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-28] Copyright header ...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/85#discussion_r39879089
--- Diff: core/rest/src/main/java/org/trafodion/rest/TransactionsResource.java ---
@@ -62,8 +69,26 @@
}
/**
- * Constructor
- * @throws IOException
+* @@@ START COPYRIGHT @@@
--- End diff --
Looks like we accidentally put the copyright into this file twice?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-28] Copyright header ...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/85#discussion_r39879229
--- Diff: core/sqf/sqenvcom.sh ---
@@ -29,8 +29,8 @@
# * Add an entry in sqf/LocalSettingsTemplate.sh to make path configurable.
##############################################################
-#Product version (Trafodion or derivative product)
-export TRAFODION_VER_PROD="Apache Trafodion "
+#Product version (Trafodion, Enterprise or Enterprise Adv)
--- End diff --
"Enterprise", "Enterprise Adv" sound like product names. Just curious why we changed this away from "deriviative product"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-28] Copyright header ...
Posted by sandhyasun <gi...@git.apache.org>.
Github user sandhyasun commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/85#discussion_r39901887
--- Diff: core/dbsecurity/scripts/sqcertgen ---
@@ -108,7 +108,7 @@ stateOrProvinceName_default = California
localityName = Locality Name (eg, city)
localityName_default = Cupertino
0.organizationName = Organization Name (eg, company)
-0.organizationName_default = Hewlett-Packard Company
+0.organizationName_default = Esgyn Corporation
--- End diff --
Will make the company name and location name generic since the customer needs to create the certificate file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-28] Copyright header ...
Posted by sandhyasun <gi...@git.apache.org>.
Github user sandhyasun commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/85#discussion_r39886282
--- Diff: core/sqf/sqenvcom.sh ---
@@ -29,8 +29,8 @@
# * Add an entry in sqf/LocalSettingsTemplate.sh to make path configurable.
##############################################################
-#Product version (Trafodion or derivative product)
-export TRAFODION_VER_PROD="Apache Trafodion "
+#Product version (Trafodion, Enterprise or Enterprise Adv)
--- End diff --
Merge conflict problem ! I had indeed corrected it in the last review. WIll revert to "derivative product".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---