You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by wujinhu <gi...@git.apache.org> on 2016/10/22 04:34:10 UTC
[GitHub] incubator-eagle pull request #550: [EAGLE-662] remove jarPath/mode from enti...
GitHub user wujinhu opened a pull request:
https://github.com/apache/incubator-eagle/pull/550
[EAGLE-662] remove jarPath/mode from entity context
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wujinhu/incubator-eagle EAGLE-662
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/550.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #550
----
commit b0b610ad98665236ebe3467ace9cd98fdde30f12
Author: wujinhu <wu...@126.com>
Date: 2016-10-22T04:33:05Z
remove jarPath/mode from entity context
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #550: [EAGLE-662] remove jarPath/mode from enti...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-eagle/pull/550
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #550: [EAGLE-662] remove jarPath/mode from enti...
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/550#discussion_r84570146
--- Diff: eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/service/ApplicationAction.java ---
@@ -70,13 +71,16 @@ public ApplicationAction(Application application, ApplicationEntity metadata, Co
this.application = application;
this.metadata = metadata;
this.runtime = ExecutionRuntimeManager.getInstance().getRuntime(application.getEnvironmentType(), serverConfig);
- Map<String, Object> executionConfig = metadata.getConfiguration();
+ Map<String, Object> executionConfig = new HashMap<>(metadata.getConfiguration());
if (executionConfig == null) {
executionConfig = Collections.emptyMap();
}
if (serverConfig.hasPath(MetricConfigs.METRIC_PREFIX_CONF)) {
LOG.warn("Ignored sever config {} = {}", MetricConfigs.METRIC_PREFIX_CONF, serverConfig.getString(MetricConfigs.METRIC_PREFIX_CONF));
}
+
+ executionConfig.put("jarPath", metadata.getJarPath());
+ executionConfig.put("mode", metadata.getMode().name());
--- End diff --
It may cause the jarPath added into configuration when installating, I think you should add only in `start` action.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---