You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "wzhj2326 (via GitHub)" <gi...@apache.org> on 2023/03/28 10:53:19 UTC
[GitHub] [shardingsphere] wzhj2326 opened a new issue, #24882: when alter storage unit, old connections did not closed
wzhj2326 opened a new issue, #24882:
URL: https://github.com/apache/shardingsphere/issues/24882
## Bug Report
**For English only**, other languages will not accept.
Before report a bug, make sure you have:
- Searched open and closed [GitHub issues](https://github.com/apache/shardingsphere/issues).
- Read documentation: [ShardingSphere Doc](https://shardingsphere.apache.org/document/current/en/overview).
Please pay attention on issues you submitted, because we maybe need more details.
If no response anymore and we cannot reproduce it on current information, we will **close it**.
Please answer these questions before submitting your issue. Thanks!
### Which version of ShardingSphere did you use?
5.3.1
### Which project did you use? ShardingSphere-JDBC or ShardingSphere-Proxy?
ShardingSphere-Proxy
when alter storage unit, old connections did not closed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhaojinchao95 commented on issue #24882: when alter storage unit, old connections did not closed
Posted by "zhaojinchao95 (via GitHub)" <gi...@apache.org>.
zhaojinchao95 commented on issue #24882:
URL: https://github.com/apache/shardingsphere/issues/24882#issuecomment-1489441962
> > <img alt="image" width="727" src="https://user-images.githubusercontent.com/33742097/228450584-8585a17a-a0fe-4d5d-9255-bb8c70354d29.png">
> > Can you try it with master branch? I can't reproduce it.
>
> @zhaojinchao95
>
> I try it with master branch,it also has the problem. Are you execute `show processlist` on the actual database ？
I 'm not execute `show processlist` on the actual database, i will try again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhaojinchao95 commented on issue #24882: when alter storage unit, old connections did not closed
Posted by "zhaojinchao95 (via GitHub)" <gi...@apache.org>.
zhaojinchao95 commented on issue #24882:
URL: https://github.com/apache/shardingsphere/issues/24882#issuecomment-1491739416
> Hi @zhaojinchao95 have you tried again?
Yeah, it looks has some problem, would you like submit a pull request to fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wzhj2326 commented on issue #24882: when alter storage unit, old connections did not closed
Posted by "wzhj2326 (via GitHub)" <gi...@apache.org>.
wzhj2326 commented on issue #24882:
URL: https://github.com/apache/shardingsphere/issues/24882#issuecomment-1488007031
> There is no change in your storage unit configuration, and then go to modify it?
@zhaojinchao95
Yes ,but when i register storage unit,it create 4 connections ,
then unregister it , remaining 2 connections，only 2 connection is closed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wzhj2326 commented on issue #24882: when alter storage unit, old connections did not closed
Posted by "wzhj2326 (via GitHub)" <gi...@apache.org>.
wzhj2326 commented on issue #24882:
URL: https://github.com/apache/shardingsphere/issues/24882#issuecomment-1491339794
Hi @zhaojinchao95 have you tried again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhaojinchao95 commented on issue #24882: when alter storage unit, old connections did not closed
Posted by "zhaojinchao95 (via GitHub)" <gi...@apache.org>.
zhaojinchao95 commented on issue #24882:
URL: https://github.com/apache/shardingsphere/issues/24882#issuecomment-1486947244
Can you show your `DistSQL`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wzhj2326 commented on issue #24882: when alter storage unit, old connections did not closed
Posted by "wzhj2326 (via GitHub)" <gi...@apache.org>.
wzhj2326 commented on issue #24882:
URL: https://github.com/apache/shardingsphere/issues/24882#issuecomment-1488245357
> <img alt="image" width="727" src="https://user-images.githubusercontent.com/33742097/228450584-8585a17a-a0fe-4d5d-9255-bb8c70354d29.png">
>
> Can you try it with master branch? I can't reproduce it.
@zhaojinchao95
I try it with master branch,it also has the problem.
Are you execute `show processlist` on the actual database ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhaojinchao95 commented on issue #24882: when alter storage unit, old connections did not closed
Posted by "zhaojinchao95 (via GitHub)" <gi...@apache.org>.
zhaojinchao95 commented on issue #24882:
URL: https://github.com/apache/shardingsphere/issues/24882#issuecomment-1487927543
There is no change in your storage unit configuration, and then go to modify it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #24882: when alter storage unit, old connections did not closed
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on issue #24882:
URL: https://github.com/apache/shardingsphere/issues/24882#issuecomment-1492164401
@wzhj2326 Indeed it is, thanks for pointing that out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang closed issue #24882: when alter storage unit, old connections did not closed
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang closed issue #24882: when alter storage unit, old connections did not closed
URL: https://github.com/apache/shardingsphere/issues/24882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhaojinchao95 commented on issue #24882: when alter storage unit, old connections did not closed
Posted by "zhaojinchao95 (via GitHub)" <gi...@apache.org>.
zhaojinchao95 commented on issue #24882:
URL: https://github.com/apache/shardingsphere/issues/24882#issuecomment-1487930322
@RaigorJiang Maybe we can intercept at distsql.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhaojinchao95 commented on issue #24882: when alter storage unit, old connections did not closed
Posted by "zhaojinchao95 (via GitHub)" <gi...@apache.org>.
zhaojinchao95 commented on issue #24882:
URL: https://github.com/apache/shardingsphere/issues/24882#issuecomment-1488038219
<img width="727" alt="image" src="https://user-images.githubusercontent.com/33742097/228450584-8585a17a-a0fe-4d5d-9255-bb8c70354d29.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wzhj2326 commented on issue #24882: when alter storage unit, old connections did not closed
Posted by "wzhj2326 (via GitHub)" <gi...@apache.org>.
wzhj2326 commented on issue #24882:
URL: https://github.com/apache/shardingsphere/issues/24882#issuecomment-1487861044
> Can you show your `DistSQL`?
REGISTER STORAGE UNIT ds_01 (URL="jdbc:mysql://172.22.3.237:3306/sharding_write_0",USER="root",PASSWORD="123456");
ALTER STORAGE UNIT ds_01 (URL="jdbc:mysql://172.22.3.237:3306/sharding_write_0",USER="root",PASSWORD="123456");
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wzhj2326 commented on issue #24882: when alter storage unit, old connections did not closed
Posted by "wzhj2326 (via GitHub)" <gi...@apache.org>.
wzhj2326 commented on issue #24882:
URL: https://github.com/apache/shardingsphere/issues/24882#issuecomment-1488329578
I think it is caused by line 88 in the following class，it got one connection but it did not closed the connection.
https://github.com/apache/shardingsphere/blob/296d2913d05fbe88eb82ea460ac932ec97164825/infra/common/src/main/java/org/apache/shardingsphere/infra/datasource/props/DataSourcePropertiesValidator.java#L71-L90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org