You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2019/08/31 22:49:58 UTC

[Impala-ASF-CR] IMPALA-8912: Avoid calling computeStats twice on HBaseScanNode

Quanlong Huang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14167 )

Change subject: IMPALA-8912: Avoid calling computeStats twice on HBaseScanNode
......................................................................

IMPALA-8912: Avoid calling computeStats twice on HBaseScanNode

As mentioned in the JIRA description, HBaseScanNode#computeStats can be
called twice if it's the root of the single node plan. The second call
is redundant since HBaseScanNode won't have any children. No children
changes during the two calls, so the second call always get the same
results. We should avoid calling HBaseScanNode#computeStats twice since
it's a heavy operation depends on HBase RPCs.

Tests:
Testing in my local env with TRACE log level. Observing the function be
called only once.

Change-Id: I4650483c0504128048630714e993b481737fd1e2
---
M fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java
1 file changed, 17 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/14167/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14167
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4650483c0504128048630714e993b481737fd1e2
Gerrit-Change-Number: 14167
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>