You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2020/07/21 05:38:27 UTC

[GitHub] [groovy] paulk-asert commented on a change in pull request #1319: Minor tweak: create `Lookup` instance according to vm plugin

paulk-asert commented on a change in pull request #1319:
URL: https://github.com/apache/groovy/pull/1319#discussion_r457848005



##########
File path: src/main/java/org/codehaus/groovy/vmplugin/v8/Java8.java
##########
@@ -636,7 +637,7 @@ private Object getInvokeSpecialHandleFallback(Method method, Object receiver) {
         }
         Class<?> declaringClass = method.getDeclaringClass();
         try {
-            return getLookupConstructor().newInstance(declaringClass, -1).

Review comment:
       Just this line I am unsure about. It will be different params passed through but I am unsure of the impact.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org