[GitHub] [lucene-solr] KoenDG opened a new pull request #881: LUCENE-8979: Code Cleanup: Use entryset for map iteration wherever possible. - part 2

[GitBox <gi...@apache.org>]

KoenDG opened a new pull request #881: LUCENE-8979: Code Cleanup: Use entryset for map iteration wherever possible. - part 2
URL: https://github.com/apache/lucene-solr/pull/881
 
 
   https://issues.apache.org/jira/browse/LUCENE-8979
   
   It appears not all instances were picked up by the previous sweep, which is strange as it's all automated. I'm hoping this is all of them.
   
   Some simple cleanup. No need to spend company/personal time reviewing this, would be good if someone had some spare time. If you don't, feel free to close this tab.
   
   It's a very simple PR: just changing keySet() to entrySet() when possible. In general just the better choice. Only really a performance gain when going over a TreeMap(as I recall at least), but in general a good idea to consistent with it.
   
   A small move in TermsComponent.java, there's no point in doing the method call to populate the field and then the very next thing that happens is an unrelated check that potentially forces a `continue`, rendering the call pointless for that iteration.
   
   All tests have run locally and succeeded.
   
   Sorry about doing this twice, I don't get how these weren't picked up the first time.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org