[jira] [Comment Edited] (MESOS-1921) Design and implement protobuf storage of IP addresses

["Evelina Dumitrescu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353926#comment-14353926 ] 

Evelina Dumitrescu edited comment on MESOS-1921 at 3/10/15 12:06 AM:
---------------------------------------------------------------------

I think that a better aproach would be to:
- Design an additional protobuffer message inside the MasterInfo message

{noformat}  
message IPv6 {
    required uint32 s6_addr1 = 1;
    required uint32 s6_addr2 = 2;
    required uint32 s6_addr3 = 3;
    required uint32 s6_addr4 = 4;
  }
{noformat}
- Add an optional field of Ipv6 type inside the MasterInfo
- An additional field for the IPv6 hostname will be needed in SlaveInfo, Offer, ContainerInfo protobuffer messages. The resolved hostnames from the IPv4 and IPv6 addresses might differ. Moreover, if the hostname cannot be resolved then a string version of the IP address will be returned)



was (Author: evelinad):
I think that a better aproach would be to:
- Design an additional protobuffer message inside the MasterInfo message
  
message IPv6 {
    required uint32 s6_addr1 = 1;
    required uint32 s6_addr2 = 2;
    required uint32 s6_addr3 = 3;
    required uint32 s6_addr4 = 4;
  }

- Add an optional field of Ipv6 type inside the MasterInfo
- An additional field for the IPv6 hostname will be needed in SlaveInfo, Offer, ContainerInfo protobuffer messages. The resolved hostnames from the IPv4 and IPv6 addresses might differ. Moreover, if the hostname cannot be resolved then a string version of the IP address will be returned)


> Design and implement protobuf storage of IP addresses
> -----------------------------------------------------
>
>                 Key: MESOS-1921
>                 URL: https://issues.apache.org/jira/browse/MESOS-1921
>             Project: Mesos
>          Issue Type: Task
>            Reporter: Dominic Hamon
>            Assignee: Evelina Dumitrescu
>
> We can use {{bytes}} type or statements like {{repeated uint32 data = 4[packed=true];}}
> {{string}} representations might add again some parsing overhead. An additional field might be necessary to specify the protocol family type (distinguish between IPv4/IPv6). For example, if we don't specify the family type we can't distinguish between these Ip addresses in the case of byte/array representation: 0:0:0:0:0:0:IPV4 and IPv4 (see http://tools.ietf.org/html/rfc4291#page-10)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)