[GitHub] [flink] Myasuka opened a new pull request #8545: [FLINK-12520] Support to provide fully-qualified domain host name in TaskManagerMetricGroup

[GitBox <gi...@apache.org>]

Myasuka opened a new pull request #8545: [FLINK-12520] Support to provide fully-qualified domain host name in TaskManagerMetricGroup
URL: https://github.com/apache/flink/pull/8545
 
 
   ## What is the purpose of the change
   
   Inspired from [Chinese user-mail](https://lists.apache.org/thread.html/e1774a42430815b689ea792103d002b1da734d6086682d34c044ef35@%3Cuser-zh.flink.apache.org%3E) which complains that host name in metrics name could only show the first part. However, their full host name is like "ambari.host12.yy" which means the first part "ambari" cannot identify anything.
   
   With this PR, we could support to let user record their full host name in the `TaskManagerMetricGroup` so that to identify metrics from different hosts.
   
   ## Brief change log
   
     - Add new option `metrics.tm.full-hostname` in `MetricOptions` to indicate whether Flink should use fully qualified host name in task manager metrics.
     - Use above metric option when `instantiateTaskManagerMetricGroup` in `TaskManagerRunner`
   
   ## Verifying this change
   This change added tests and can be verified as follows:
   
     - Added test that `TaskManagerLocation#getHostName(InetAddress, boolean)` could return the host name as expected.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **yes**
     - If yes, how is the feature documented? **docs**
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services