You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "snuyanzin (via GitHub)" <gi...@apache.org> on 2024/03/26 21:38:37 UTC

[PR] [FLINK-34941][checkpoint] Add `CollectIteratorAssert#matchesRecordsFromSource` and `SinkTestSuiteBase#checkResultWithSemantic` with former signature [flink]

snuyanzin opened a new pull request, #24571:
URL: https://github.com/apache/flink/pull/24571

   ## What is the purpose of the change
   
   The PR introduces `CollectIteratorAssert#matchesRecordsFromSource` and `SinkTestSuiteBase#checkResultWithSemantic` with former signature to make downstream projects (e.g. flink-connector-elasticsearch compilable)
   
   
   ## Verifying this change
   
   
   
   This change is a trivial rework 
   
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (/ no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes )
     - The serializers: (yes / no / don't know)
     - The runtime per-record code paths (performance sensitive): ( no )
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no )
     - The S3 file system connector: ( no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? ( no)
     - If yes, how is the feature documented? (not applicable )
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34941][checkpoint] Add `CollectIteratorAssert#matchesRecordsFromSource` and `SinkTestSuiteBase#checkResultWithSemantic` with former signature [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24571:
URL: https://github.com/apache/flink/pull/24571#issuecomment-2021523128

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "51baa4e6f3c83fc4050c50b54dd69c2e8f16f2f5",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "51baa4e6f3c83fc4050c50b54dd69c2e8f16f2f5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 51baa4e6f3c83fc4050c50b54dd69c2e8f16f2f5 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34941][checkpoint] Add `CollectIteratorAssert#matchesRecordsFromSource` and `SinkTestSuiteBase#checkResultWithSemantic` with former signature [flink]

Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #24571:
URL: https://github.com/apache/flink/pull/24571#issuecomment-2021520200

   @Zakelly , @masteryhx could you please have a look since it is related to the change where you were participated [FLINK-34516](https://issues.apache.org/jira/browse/FLINK-34516)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34941][checkpoint] Add `CollectIteratorAssert#matchesRecordsFromSource` and `SinkTestSuiteBase#checkResultWithSemantic` with former signature [flink]

Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin merged PR #24571:
URL: https://github.com/apache/flink/pull/24571


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34941][checkpoint] Add `CollectIteratorAssert#matchesRecordsFromSource` and `SinkTestSuiteBase#checkResultWithSemantic` with former signature [flink]

Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #24571:
URL: https://github.com/apache/flink/pull/24571#issuecomment-2022162372

   Thanks for taking a look
   yep that's becoming a bit more complicated after connector's externalisation...
   at least we were able to identify this before the release


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org